Skip to content

fix: reorder cleanupAtContainer code #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

MarkFalconbridge
Copy link
Contributor

Closes #326

What:

Why:

How:

Checklist:

  • Documentation added to the docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged
  • Added myself to contributors table

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍 thanks!

@kentcdodds kentcdodds merged commit ca313f2 into testing-library:master Mar 19, 2019
@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cleanupAtContainer should call ReactDOM.unmountComponentAtNode before removing the container from the DOM
2 participants