Skip to content

Update Typings #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Update Typings #331

merged 1 commit into from
Mar 21, 2019

Conversation

pschyma
Copy link
Contributor

@pschyma pschyma commented Mar 21, 2019

Closes #330

What:
Extend the typings of Query interface to match those from dom-testing-library.

Why:

How:

Checklist:

  • Documentation added to the docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged
  • Added myself to contributors table

Extend the typings of Query interface to match those from dom-testing-library.
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we export the query typings from dom-testing-library and use them here instead of copying them like this?

@kentcdodds kentcdodds merged commit aed35f4 into testing-library:master Mar 21, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @pschyma for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @pschyma! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript Error with latest dom-testing-library
2 participants