fix(act): add try/catch around react-dom/test-utils require #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 41 43 +2
Branches 7 7
=====================================
+ Hits 41 43 +2
Continue to review full report at Codecov.
|
|
If I could get one review that would be stellar 👍 |
alexkrolick
approved these changes
Apr 1, 2019
alexkrolick
reviewed
Apr 1, 2019
|
|
||
| let reactAct | ||
| try { | ||
| reactAct = require('react-dom/test-utils').act |
There was a problem hiding this comment.
Will this throw if act is not defined but the test-utils package is?
There was a problem hiding this comment.
No it wont, but we'll handle it fine anyway thanks to the || below 👍
|
🎉 This PR is included in version 6.0.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: add try/catch around react-dom/test-utils require
Why: Closes #315
How: replace import with require so we can make it happen dynamically
Checklist: