Skip to content

fix(act): wait until react-dom-16.9.0 is released #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

kentcdodds
Copy link
Member

What: This suppresses the warning about upgrading to [email protected] until that's actually released...

Why: Because it may not be released for a while 😬

How: in a funny way I guess. But it allows us to keep our tests in place.

Checklist:

  • Documentation added to the
    docs site N/A
  • Tests
  • Typescript definitions updated N/A
  • Ready to be merged

@kentcdodds kentcdodds force-pushed the pr/suppress-warning branch from 8793f1e to dc6801c Compare April 5, 2019 16:45
@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #344 into master will decrease coverage by 1.58%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage     100%   98.41%   -1.59%     
==========================================
  Files           2        3       +1     
  Lines          62       63       +1     
  Branches       10       10              
==========================================
  Hits           62       62              
- Misses          0        1       +1
Impacted Files Coverage Δ
src/act-compat.js 95.83% <100%> (-4.17%) ⬇️
src/react-dom-16.9.0-is-released.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a88da2...dc6801c. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #344 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #344   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines          62     59    -3     
  Branches       10      8    -2     
=====================================
- Hits           62     59    -3
Impacted Files Coverage Δ
src/act-compat.js 100% <100%> (ø) ⬆️
src/react-dom-16.9.0-is-released.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a88da2...dc6801c. Read the comment docs.

@kentcdodds kentcdodds merged commit 180179e into master Apr 5, 2019
@kentcdodds kentcdodds deleted the pr/suppress-warning branch April 5, 2019 16:49
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant