Skip to content

Commit 02224fa

Browse files
laoarKernel Patches Daemon
laoar
authored and
Kernel Patches Daemon
committed
selftests/bpf: Add selftests for cgroup controller
Add selftests for cgroup controller on both cgroup1 and cgroup2. The result as follows, $ tools/testing/selftests/bpf/test_progs --name=cgroup_controller #40/1 cgroup_controller/test_cgroup1_controller:OK #40/2 cgroup_controller/test_invalid_cgroup_id:OK #40/3 cgroup_controller/test_sleepable_prog:OK #40/4 cgroup_controller/test_cgroup2_controller:OK #40 cgroup_controller:OK Signed-off-by: Yafang Shao <[email protected]>
1 parent f2fa76e commit 02224fa

File tree

2 files changed

+229
-0
lines changed

2 files changed

+229
-0
lines changed

‎tools/testing/selftests/bpf/prog_tests/cgroup_controller.c

Lines changed: 149 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,149 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
/* Copyright (C) 2023 Yafang Shao <[email protected]> */
3+
4+
#include <sys/types.h>
5+
#include <unistd.h>
6+
#include <test_progs.h>
7+
#include "cgroup_helpers.h"
8+
#include "test_cgroup_controller.skel.h"
9+
10+
#define CGROUP2_DIR "/cgroup2_controller"
11+
12+
static void bpf_cgroup1_controller(bool sleepable, __u64 cgrp_id)
13+
{
14+
struct test_cgroup_controller *skel;
15+
int err;
16+
17+
skel = test_cgroup_controller__open();
18+
if (!ASSERT_OK_PTR(skel, "open"))
19+
return;
20+
21+
skel->bss->target_pid = getpid();
22+
skel->bss->ancestor_cgid = cgrp_id;
23+
24+
err = bpf_program__set_attach_target(skel->progs.fentry_run, 0, "bpf_fentry_test1");
25+
if (!ASSERT_OK(err, "fentry_set_target"))
26+
goto cleanup;
27+
28+
err = test_cgroup_controller__load(skel);
29+
if (!ASSERT_OK(err, "load"))
30+
goto cleanup;
31+
32+
/* Attach LSM prog first */
33+
if (!sleepable) {
34+
skel->links.lsm_net_cls = bpf_program__attach_lsm(skel->progs.lsm_net_cls);
35+
if (!ASSERT_OK_PTR(skel->links.lsm_net_cls, "lsm_attach"))
36+
goto cleanup;
37+
} else {
38+
skel->links.lsm_s_net_cls = bpf_program__attach_lsm(skel->progs.lsm_s_net_cls);
39+
if (!ASSERT_OK_PTR(skel->links.lsm_s_net_cls, "lsm_attach_sleepable"))
40+
goto cleanup;
41+
}
42+
43+
/* LSM prog will be triggered when attaching fentry */
44+
skel->links.fentry_run = bpf_program__attach_trace(skel->progs.fentry_run);
45+
if (cgrp_id) {
46+
ASSERT_NULL(skel->links.fentry_run, "fentry_attach_fail");
47+
} else {
48+
if (!ASSERT_OK_PTR(skel->links.fentry_run, "fentry_attach_success"))
49+
goto cleanup;
50+
}
51+
52+
cleanup:
53+
test_cgroup_controller__destroy(skel);
54+
}
55+
56+
static void cgroup_controller_on_cgroup1(bool sleepable, bool invalid_cgid)
57+
{
58+
__u64 cgrp_id;
59+
int err;
60+
61+
/* Setup cgroup1 hierarchy */
62+
err = setup_classid_environment();
63+
if (!ASSERT_OK(err, "setup_classid_environment"))
64+
return;
65+
66+
err = join_classid();
67+
if (!ASSERT_OK(err, "join_cgroup1"))
68+
goto cleanup;
69+
70+
cgrp_id = get_classid_cgroup_id();
71+
if (invalid_cgid)
72+
bpf_cgroup1_controller(sleepable, 0);
73+
else
74+
bpf_cgroup1_controller(sleepable, cgrp_id);
75+
76+
cleanup:
77+
/* Cleanup cgroup1 hierarchy */
78+
cleanup_classid_environment();
79+
}
80+
81+
static void bpf_cgroup2_controller(__u64 cgrp_id)
82+
{
83+
struct test_cgroup_controller *skel;
84+
int err;
85+
86+
skel = test_cgroup_controller__open();
87+
if (!ASSERT_OK_PTR(skel, "open"))
88+
return;
89+
90+
skel->bss->target_pid = getpid();
91+
skel->bss->ancestor_cgid = cgrp_id;
92+
93+
err = bpf_program__set_attach_target(skel->progs.fentry_run, 0, "bpf_fentry_test1");
94+
if (!ASSERT_OK(err, "fentry_set_target"))
95+
goto cleanup;
96+
97+
err = test_cgroup_controller__load(skel);
98+
if (!ASSERT_OK(err, "load"))
99+
goto cleanup;
100+
101+
skel->links.lsm_cpu = bpf_program__attach_lsm(skel->progs.lsm_cpu);
102+
if (!ASSERT_OK_PTR(skel->links.lsm_cpu, "lsm_attach"))
103+
goto cleanup;
104+
105+
skel->links.fentry_run = bpf_program__attach_trace(skel->progs.fentry_run);
106+
ASSERT_NULL(skel->links.fentry_run, "fentry_attach_fail");
107+
108+
cleanup:
109+
test_cgroup_controller__destroy(skel);
110+
}
111+
112+
static void cgroup_controller_on_cgroup2(void)
113+
{
114+
int cgrp_fd, cgrp_id, err;
115+
116+
err = setup_cgroup_environment();
117+
if (!ASSERT_OK(err, "cgrp2_env_setup"))
118+
goto cleanup;
119+
120+
cgrp_fd = test__join_cgroup(CGROUP2_DIR);
121+
if (!ASSERT_GE(cgrp_fd, 0, "cgroup_join_cgroup2"))
122+
goto cleanup;
123+
124+
err = enable_controllers(CGROUP2_DIR, "cpu");
125+
if (!ASSERT_OK(err, "cgrp2_env_setup"))
126+
goto close_fd;
127+
128+
cgrp_id = get_cgroup_id(CGROUP2_DIR);
129+
if (!ASSERT_GE(cgrp_id, 0, "cgroup2_id"))
130+
goto close_fd;
131+
bpf_cgroup2_controller(cgrp_id);
132+
133+
close_fd:
134+
close(cgrp_fd);
135+
cleanup:
136+
cleanup_cgroup_environment();
137+
}
138+
139+
void test_cgroup_controller(void)
140+
{
141+
if (test__start_subtest("test_cgroup1_controller"))
142+
cgroup_controller_on_cgroup1(false, false);
143+
if (test__start_subtest("test_invalid_cgroup_id"))
144+
cgroup_controller_on_cgroup1(false, true);
145+
if (test__start_subtest("test_sleepable_prog"))
146+
cgroup_controller_on_cgroup1(true, false);
147+
if (test__start_subtest("test_cgroup2_controller"))
148+
cgroup_controller_on_cgroup2();
149+
}

‎tools/testing/selftests/bpf/progs/test_cgroup_controller.c

Lines changed: 80 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,80 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
//#endif
3+
/* Copyright (C) 2023 Yafang Shao <[email protected]> */
4+
5+
#include "vmlinux.h"
6+
#include <bpf/bpf_helpers.h>
7+
#include <bpf/bpf_tracing.h>
8+
#include <bpf/bpf_core_read.h>
9+
10+
__u64 ancestor_cgid;
11+
int target_pid;
12+
13+
struct cgroup *bpf_cgroup_acquire_from_id_within_controller(u64 cgid, int ssid) __ksym;
14+
u64 bpf_cgroup_id_from_task_within_controller(struct task_struct *task, int ssid) __ksym;
15+
u64 bpf_cgroup_ancestor_id_from_task_within_controller(struct task_struct *task,
16+
int ssid, int level) __ksym;
17+
long bpf_task_under_cgroup(struct task_struct *task, struct cgroup *ancestor) __ksym;
18+
void bpf_cgroup_release(struct cgroup *p) __ksym;
19+
20+
static int bpf_link_create_verify(int cmd, union bpf_attr *attr, unsigned int size, int ssid)
21+
{
22+
struct cgroup *cgrp = NULL;
23+
struct task_struct *task;
24+
__u64 cgid, root_cgid;
25+
int ret = 0;
26+
27+
if (cmd != BPF_LINK_CREATE)
28+
return 0;
29+
30+
task = bpf_get_current_task_btf();
31+
/* Then it can run in parallel */
32+
if (target_pid != BPF_CORE_READ(task, pid))
33+
return 0;
34+
35+
cgrp = bpf_cgroup_acquire_from_id_within_controller(ancestor_cgid, ssid);
36+
if (!cgrp)
37+
goto out;
38+
39+
if (bpf_task_under_cgroup(task, cgrp))
40+
ret = -1;
41+
bpf_cgroup_release(cgrp);
42+
43+
cgid = bpf_cgroup_id_from_task_within_controller(task, ssid);
44+
if (cgid != ancestor_cgid)
45+
ret = 0;
46+
47+
/* The level of root cgroup is 0, and its id is always 1 */
48+
root_cgid = bpf_cgroup_ancestor_id_from_task_within_controller(task, ssid, 0);
49+
if (root_cgid != 1)
50+
ret = 0;
51+
52+
out:
53+
return ret;
54+
}
55+
56+
SEC("lsm/bpf")
57+
int BPF_PROG(lsm_net_cls, int cmd, union bpf_attr *attr, unsigned int size)
58+
{
59+
return bpf_link_create_verify(cmd, attr, size, net_cls_cgrp_id);
60+
}
61+
62+
SEC("lsm.s/bpf")
63+
int BPF_PROG(lsm_s_net_cls, int cmd, union bpf_attr *attr, unsigned int size)
64+
{
65+
return bpf_link_create_verify(cmd, attr, size, net_cls_cgrp_id);
66+
}
67+
68+
SEC("lsm/bpf")
69+
int BPF_PROG(lsm_cpu, int cmd, union bpf_attr *attr, unsigned int size)
70+
{
71+
return bpf_link_create_verify(cmd, attr, size, cpu_cgrp_id);
72+
}
73+
74+
SEC("fentry")
75+
int BPF_PROG(fentry_run)
76+
{
77+
return 0;
78+
}
79+
80+
char _license[] SEC("license") = "GPL";

0 commit comments

Comments
 (0)