selftests/bpf: Remove redundant checks in get_stack_print_output()

ytcoode · Nobody · commit 397b3a03c7a3 · 2022-04-05T13:49:39.000-07:00
The checks preceding CHECK macro are redundant, remove them.

Signed-off-by: Yuntao Wang &lt;ytcoode@gmail.com&gt;
diff --git a/tools/testing/selftests/bpf/prog_tests/get_stack_raw_tp.c b/tools/testing/selftests/bpf/prog_tests/get_stack_raw_tp.c
@@ -76,10 +76,8 @@ static void get_stack_print_output(void *ctx, int cpu, void *data, __u32 size)
 			good_user_stack = true;
 	}
 
-	if (!good_kern_stack)
-	    CHECK(!good_kern_stack, "kern_stack", "corrupted kernel stack\n");
-	if (!good_user_stack)
-	    CHECK(!good_user_stack, "user_stack", "corrupted user stack\n");
+	CHECK(!good_kern_stack, "kern_stack", "corrupted kernel stack\n");
+	CHECK(!good_user_stack, "user_stack", "corrupted user stack\n");
 }
 
 void test_get_stack_raw_tp(void)

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,8 @@ static void get_stack_print_output(void ctx, int cpu, void data, __u32 size)`
`76`	`76`	`good_user_stack = true;`
`77`	`77`	`}`
`78`	`78`
`79`		`- if (!good_kern_stack)`
`80`		`- CHECK(!good_kern_stack, "kern_stack", "corrupted kernel stack\n");`
`81`		`- if (!good_user_stack)`
`82`		`- CHECK(!good_user_stack, "user_stack", "corrupted user stack\n");`
	`79`	`+ CHECK(!good_kern_stack, "kern_stack", "corrupted kernel stack\n");`
	`80`	`+ CHECK(!good_user_stack, "user_stack", "corrupted user stack\n");`
`83`	`81`	`}`
`84`	`82`
`85`	`83`	`void test_get_stack_raw_tp(void)`