selftests/bpf: consolidate common code in run_one_test function

This is a pre-req to add separate logging for each subtest.

Move all the mutable test data to the test_result struct.
Move per-test init/de-init into the run_one_test function.
Consolidate data aggregation and final log output in
calculate_and_print_summary function.
As a side effect, this patch fixes double counting of errors
for subtests and possible duplicate output of subtest log
on failures.

Also, add prog_tests_framework.c test to verify some of the
counting logic.

As part of verification, confirmed that number of reported
tests is the same before and after the change for both parallel
and sequential test execution.

Signed-off-by: Mykola Lysenko <[email protected]>

Author: mykola-lysenko

tools/testing/selftests/bpf/prog_tests/prog_tests_framework.c

@@ -0,0 +1,55 @@
+// SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause)
+
+#include "test_progs.h"
+#include "testing_helpers.h"
+
+static void clear_test_result(struct test_result *result)
+{
+	result->error_cnt = 0;
+	result->sub_succ_cnt = 0;
+	result->skip_cnt = 0;
+}
+
+void test_prog_tests_framework(void)
+{
+	struct test_result *result = env.test_result;
+
+	// in all the ASSERT calls below we need to return on the first
+	// error due to the fact that we are cleaning the test state after
+	// each dummy subtest
+
+	// test we properly count skipped tests with subtests
+	if (test__start_subtest("test_good_subtest"))
+		test__end_subtest();
+	if (!ASSERT_EQ(result->skip_cnt, 0, "skip_cnt_check"))
+		return;
+	if (!ASSERT_EQ(result->error_cnt, 0, "error_cnt_check"))
+		return;
+	if (!ASSERT_EQ(result->subtest_num, 1, "subtest_num_check"))
+		return;
+	clear_test_result(result);
+
+	if (test__start_subtest("test_skip_subtest")) {
+		test__skip();
+		test__end_subtest();
+	}
+	if (test__start_subtest("test_skip_subtest")) {
+		test__skip();
+		test__end_subtest();
+	}
+	if (!ASSERT_EQ(result->skip_cnt, 2, "skip_cnt_check"))
+		return;
+	if (!ASSERT_EQ(result->subtest_num, 3, "subtest_num_check"))
+		return;
+	clear_test_result(result);
+
+	if (test__start_subtest("test_fail_subtest")) {
+		test__fail();
+		test__end_subtest();
+	}
+	if (!ASSERT_EQ(result->error_cnt, 1, "error_cnt_check"))
+		return;
+	if (!ASSERT_EQ(result->subtest_num, 4, "subtest_num_check"))
+		return;
+	clear_test_result(result);
+}