Skip to content

Commit b5f9a01

Browse files
zhijianli88rleon
authored andcommitted
RDMA/rxe: Fix mr leak in RESPST_ERR_RNR
rxe_recheck_mr() will increase mr's ref_cnt, so we should call rxe_put(mr) to drop mr's ref_cnt in RESPST_ERR_RNR to avoid below warning: WARNING: CPU: 0 PID: 4156 at drivers/infiniband/sw/rxe/rxe_pool.c:259 __rxe_cleanup+0x1df/0x240 [rdma_rxe] ... Call Trace: rxe_dereg_mr+0x4c/0x60 [rdma_rxe] ib_dereg_mr_user+0xa8/0x200 [ib_core] ib_mr_pool_destroy+0x77/0xb0 [ib_core] nvme_rdma_destroy_queue_ib+0x89/0x240 [nvme_rdma] nvme_rdma_free_queue+0x40/0x50 [nvme_rdma] nvme_rdma_teardown_io_queues.part.0+0xc3/0x120 [nvme_rdma] nvme_rdma_error_recovery_work+0x4d/0xf0 [nvme_rdma] process_one_work+0x582/0xa40 ? pwq_dec_nr_in_flight+0x100/0x100 ? rwlock_bug.part.0+0x60/0x60 worker_thread+0x2a9/0x700 ? process_one_work+0xa40/0xa40 kthread+0x168/0x1a0 ? kthread_complete_and_exit+0x20/0x20 ret_from_fork+0x22/0x30 Link: https://lore.kernel.org/r/[email protected] Fixes: 8a1a0be ("RDMA/rxe: Replace mr by rkey in responder resources") Signed-off-by: Li Zhijian <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent 12bcaf8 commit b5f9a01

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/infiniband/sw/rxe/rxe_resp.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -806,8 +806,10 @@ static enum resp_states read_reply(struct rxe_qp *qp,
806806

807807
skb = prepare_ack_packet(qp, &ack_pkt, opcode, payload,
808808
res->cur_psn, AETH_ACK_UNLIMITED);
809-
if (!skb)
809+
if (!skb) {
810+
rxe_put(mr);
810811
return RESPST_ERR_RNR;
812+
}
811813

812814
rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt),
813815
payload, RXE_FROM_MR_OBJ);

0 commit comments

Comments
 (0)