Skip to content

Commit f23bd28

Browse files
kzysKirtana Ashok
authored and
Kirtana Ashok
committed
Embed "Unimplemented" structs as proto recommended
Embedding these structs will be mandatory after migratring off from gogo/protobuf (see containerd#6564). Signed-off-by: Kazuyoshi Kato <[email protected]>
1 parent d8bc609 commit f23bd28

File tree

14 files changed

+14
-0
lines changed

14 files changed

+14
-0
lines changed

contrib/snapshotservice/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ var empty = &ptypes.Empty{}
3232

3333
type service struct {
3434
sn snapshots.Snapshotter
35+
snapshotsapi.UnimplementedSnapshotsServer
3536
}
3637

3738
// FromSnapshotter returns a Snapshot API server from a containerd snapshotter

services/containers/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func init() {
5555

5656
type service struct {
5757
local api.ContainersClient
58+
api.UnimplementedContainersServer
5859
}
5960

6061
var _ api.ContainersServer = &service{}

services/content/contentserver/contentserver.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ import (
3838

3939
type service struct {
4040
store content.Store
41+
api.UnimplementedContentServer
4142
}
4243

4344
var bufPool = sync.Pool{

services/diff/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func init() {
5353

5454
type service struct {
5555
local diffapi.DiffClient
56+
diffapi.UnimplementedDiffServer
5657
}
5758

5859
var _ diffapi.DiffServer = &service{}

services/events/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ func init() {
5252
type service struct {
5353
ttService *ttrpcService
5454
events *exchange.Exchange
55+
api.UnimplementedEventsServer
5556
}
5657

5758
// NewService returns the GRPC events server

services/images/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ func init() {
5454

5555
type service struct {
5656
local imagesapi.ImagesClient
57+
imagesapi.UnimplementedImagesServer
5758
}
5859

5960
var _ imagesapi.ImagesServer = &service{}

services/introspection/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ func init() {
6262

6363
type server struct {
6464
local api.IntrospectionClient
65+
api.UnimplementedIntrospectionServer
6566
}
6667

6768
var _ = (api.IntrospectionServer)(&server{})

services/leases/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ func init() {
4747

4848
type service struct {
4949
lm leases.Manager
50+
api.UnimplementedLeasesServer
5051
}
5152

5253
func (s *service) Register(server *grpc.Server) error {

services/namespaces/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ func init() {
5454

5555
type service struct {
5656
local api.NamespacesClient
57+
api.UnimplementedNamespacesServer
5758
}
5859

5960
var _ api.NamespacesServer = &service{}

services/sandbox/controller_service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ func init() {
5959

6060
type controllerService struct {
6161
local api.ControllerClient
62+
api.UnimplementedControllerServer
6263
}
6364

6465
var _ api.ControllerServer = (*controllerService)(nil)

services/sandbox/store_service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ func init() {
5555

5656
type sandboxService struct {
5757
local api.StoreClient
58+
api.UnimplementedStoreServer
5859
}
5960

6061
var _ api.StoreServer = (*sandboxService)(nil)

services/snapshots/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ var empty = &ptypes.Empty{}
4848

4949
type service struct {
5050
ss map[string]snapshots.Snapshotter
51+
snapshotsapi.UnimplementedSnapshotsServer
5152
}
5253

5354
func newService(ic *plugin.InitContext) (interface{}, error) {

services/tasks/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ func init() {
5858

5959
type service struct {
6060
local api.TasksClient
61+
api.UnimplementedTasksServer
6162
}
6263

6364
func (s *service) Register(server *grpc.Server) error {

services/version/service.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func initFunc(ic *plugin.InitContext) (interface{}, error) {
4141
}
4242

4343
type service struct {
44+
api.UnimplementedVersionServer
4445
}
4546

4647
func (s *service) Register(server *grpc.Server) error {

0 commit comments

Comments
 (0)