Fix review findings

kimkulling · web-flow · commit d2048269e840 · 2025-06-25T21:36:07.000+02:00
diff --git a/include/cppcore/Common/TStringBase.h b/include/cppcore/Common/TStringBase.h
@@ -122,11 +122,12 @@ inline void TStringBase<T>::clear() {
         mStringBuffer = nullptr;
         mCapacity = InitSize;
     }
-    mSize = 0;
+    reset();
 }
 
 template <class T>
 inline void TStringBase<T>::copyFrom(TStringBase<T> &base, const T *ptr, size_t size) {
+    static_assert(std::is_trivially_copyable_v<T>, "T must be trivially copyable");
     if (ptr != nullptr) {
         T *targetPtr = base.mBuffer;
         

Original file line number	Diff line number	Diff line change
`@@ -122,11 +122,12 @@ inline void TStringBase<T>::clear() {`
`122`	`122`	`mStringBuffer = nullptr;`
`123`	`123`	`mCapacity = InitSize;`
`124`	`124`	`}`
`125`		`- mSize = 0;`
	`125`	`+ reset();`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`template <class T>`
`129`	`129`	`inline void TStringBase<T>::copyFrom(TStringBase<T> &base, const T *ptr, size_t size) {`
	`130`	`+ static_assert(std::is_trivially_copyable_v<T>, "T must be trivially copyable");`
`130`	`131`	`if (ptr != nullptr) {`
`131`	`132`	`T *targetPtr = base.mBuffer;`
`132`	`133`