Cleanup + fix some broken recipes

Author: misl6

ci/constants.py

@@ -32,10 +32,8 @@ class TargetPython(Enum):
     'zope_interface',
     # Requires zope_interface, which is broken.
     'twisted',
-    # Mirko: FIXME
-    'icu',
+    # genericndkbuild is incompatible with sdl2 (which is build by default when targeting sdl2 bootstrap)
     'genericndkbuild',
-    'evdev'
 ])
 
 BROKEN_RECIPES = {

pythonforandroid/recipes/evdev/__init__.py

@@ -5,6 +5,7 @@ class EvdevRecipe(CompiledComponentsPythonRecipe):
     name = 'evdev'
     version = 'v0.4.7'
     url = 'https://github.com/gvalkov/python-evdev/archive/{version}.zip'
+    call_hostpython_via_targetpython = False
 
     depends = []
 

pythonforandroid/recipes/icu/__init__.py

@@ -29,7 +29,6 @@ class ICURecipe(Recipe):
         'libicutu{}.so'.format(major_version): 'build_icu_android/lib',
         'libiculx{}.so'.format(major_version): 'build_icu_android/lib',
     }
-    need_stl_shared = True
 
     @property
     def versioned_url(self):
@@ -94,7 +93,6 @@ def make_build_dest(dest):
                     _env=host_env)
                 shprint(sh.make, "-j", str(cpu_count()), _env=host_env)
                 shprint(sh.make, "install", _env=host_env)
-
         build_android, exists = make_build_dest("build_icu_android")
         if not exists:
             configure = sh.Command(join(build_root, "source", "configure"))

pythonforandroid/recipes/libffi/__init__.py

@@ -21,13 +21,6 @@ class LibffiRecipe(Recipe):
 
     built_libraries = {'libffi.so': '.libs'}
 
-    """
-    def get_recipe_env(self, arch=None):
-        env = super().get_recipe_env(arch)
-        env['STRIP'] = ''
-        return env
-    """
-
     def build_arch(self, arch):
         env = self.get_recipe_env(arch)
         with current_directory(self.get_build_dir(arch.arch)):

pythonforandroid/recipes/libiconv/__init__.py

@@ -13,8 +13,6 @@ class LibIconvRecipe(Recipe):
 
     built_libraries = {'libiconv.so': 'lib/.libs'}
 
-    # patches = ['libiconv-1.15-no-gets.patch']
-
     def build_arch(self, arch):
         env = self.get_recipe_env(arch)
         with current_directory(self.get_build_dir(arch.arch)):