Skip to content

Commit e9dd48f

Browse files
committed
Fix tests for icu and try a fix for openal
1 parent 0645c59 commit e9dd48f

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

pythonforandroid/recipes/openal/__init__.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77

88
class OpenALRecipe(NDKRecipe):
9-
version = '1.18.2'
9+
version = '1.21.1'
1010
url = 'https://github.com/kcat/openal-soft/archive/openal-soft-{version}.tar.gz'
1111

1212
generated_libraries = ['libopenal.so']
@@ -21,7 +21,10 @@ def build_arch(self, arch):
2121
with current_directory(self.get_build_dir(arch.arch)):
2222
env = self.get_recipe_env(arch)
2323
cmake_args = [
24-
'-DCMAKE_TOOLCHAIN_FILE={}'.format('XCompile-Android.txt'),
24+
"-DANDROID_STL=" + self.stl_lib_name,
25+
"-DCMAKE_TOOLCHAIN_FILE={}".format(
26+
join(self.ctx.ndk_dir, "build", "cmake", "android.toolchain.cmake")
27+
),
2528
]
2629
shprint(
2730
sh.cmake, '.',

tests/recipes/test_icu.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class TestIcuRecipe(RecipeCtx, unittest.TestCase):
1616

1717
def test_url(self):
1818
self.assertTrue(self.recipe.versioned_url.startswith("http"))
19-
self.assertIn(self.recipe.version, self.recipe.versioned_url)
19+
self.assertIn(self.recipe.version.replace('.', '-'), self.recipe.versioned_url)
2020

2121
@mock.patch(
2222
"pythonforandroid.recipe.Recipe.url", new_callable=mock.PropertyMock

0 commit comments

Comments
 (0)