Ensure the host window controller is destroyed before the lifecycle manager

Author: hbatagelo

engine/src/flutter/shell/platform/windows/flutter_windows_engine.cc

@@ -239,6 +239,7 @@ FlutterWindowsEngine::FlutterWindowsEngine(
 
 FlutterWindowsEngine::~FlutterWindowsEngine() {
   messenger_->SetEngine(nullptr);
+  host_window_controller_.reset();
   Stop();
 }
 

engine/src/flutter/shell/platform/windows/flutter_windows_view.cc

@@ -121,9 +121,7 @@ FlutterWindowsView::FlutterWindowsView(
 FlutterWindowsView::~FlutterWindowsView() {
   // The view owns the child window.
   // Notify the engine the view's child window will no longer be visible.
-  if (engine_->running()) {
-    engine_->OnWindowStateEvent(GetWindowHandle(), WindowStateEvent::kHide);
-  }
+  engine_->OnWindowStateEvent(GetWindowHandle(), WindowStateEvent::kHide);
 
   if (surface_) {
     DestroyWindowSurface(*engine_, std::move(surface_));
@@ -815,9 +813,7 @@ void FlutterWindowsView::OnDwmCompositionChanged() {
 }
 
 void FlutterWindowsView::OnWindowStateEvent(HWND hwnd, WindowStateEvent event) {
-  if (engine_->running()) {
-    engine_->OnWindowStateEvent(hwnd, event);
-  }
+  engine_->OnWindowStateEvent(hwnd, event);
 }
 
 bool FlutterWindowsView::NeedsVsync() const {

engine/src/flutter/shell/platform/windows/flutter_windows_view_unittests.cc

@@ -279,7 +279,6 @@ TEST(FlutterWindowsViewTest, Shutdown) {
     EXPECT_CALL(*engine_ptr, running).WillOnce(Return(true));
     EXPECT_CALL(*engine_ptr, RemoveView(view_id)).Times(1);
     EXPECT_CALL(*engine_ptr, running).WillOnce(Return(true));
-    EXPECT_CALL(*engine_ptr, running).WillOnce(Return(true));
     EXPECT_CALL(*engine_ptr, PostRasterThreadTask)
         .WillOnce([](fml::closure callback) {
           callback();