refactor: remove references to WindowingApp from the window.dart API (#21)

* refactor: remove references to WindowingApp from the window.dart API

* bugfix: notify listeners when values change on a window controller

Author: mattkae

examples/multi_window_ref_app/lib/main.dart

@@ -7,9 +7,7 @@ void main() {
     sizeConstraints: const BoxConstraints(minWidth: 640, minHeight: 480),
     title: "Multi-Window Reference Application",
   );
-  runWidget(WindowingApp(children: <Widget>[
-    RegularWindow(
-        controller: controller,
-        child: MaterialApp(home: MainWindow(mainController: controller)))
-  ]));
+  runWidget(RegularWindow(
+      controller: controller,
+      child: MaterialApp(home: MainWindow(mainController: controller))));
 }

packages/flutter/lib/src/widgets/window.dart

@@ -40,18 +40,21 @@ abstract class WindowController with ChangeNotifier {
           _view = metadata.view;
           _state = metadata.state;
           _size = metadata.size;
+          notifyListeners();
 
           SchedulerBinding.instance.addPostFrameCallback((_) async {
             _listener = _WindowListener(
               viewId: metadata.view.viewId,
               onChanged: (_WindowChangeProperties properties) {
                 if (properties.size != null) {
                   _size = properties.size!;
+                  notifyListeners();
                 }
               },
               onDestroyed: () {
                 _view = null;
                 _isPendingDestroy = false;
+                notifyListeners();
                 onDestroyed?.call();
               },
             );
@@ -381,39 +384,3 @@ class _WindowingAppGlobalData {
     _listeners.add(listener);
   }
 }
-
-/// Declares that an application will create multiple windows.
-class WindowingApp extends StatefulWidget {
-  /// Creates a new windowing app with the provided child windows.
-  const WindowingApp({super.key, required this.children});
-
-  /// A list of initial windows to render. These windows will be placed inside
-  /// of a [ViewCollection].
-  final List<Widget> children;
-
-  @override
-  State<WindowingApp> createState() => _WindowingAppState();
-}
-
-class _WindowingAppState extends State<WindowingApp> {
-  @override
-  Widget build(BuildContext context) {
-    return _WindowingAppContext(windowingApp: this, child: ViewCollection(views: widget.children));
-  }
-}
-
-class _WindowingAppContext extends InheritedWidget {
-  const _WindowingAppContext({super.key, required super.child, required this.windowingApp});
-
-  final _WindowingAppState windowingApp;
-
-  /// Returns the [MultiWindowAppContext] if any
-  static _WindowingAppContext? of(BuildContext context) {
-    return context.dependOnInheritedWidgetOfExactType<_WindowingAppContext>();
-  }
-
-  @override
-  bool updateShouldNotify(_WindowingAppContext oldWidget) {
-    return windowingApp != oldWidget.windowingApp;
-  }
-}

packages/flutter/test/widgets/window_test.dart

@@ -46,9 +46,7 @@ void main() {
       wrapWithView: false,
       Builder(
         builder: (BuildContext context) {
-          return WindowingApp(
-            children: <Widget>[RegularWindow(controller: controller, child: Container())],
-          );
+          return RegularWindow(controller: controller, child: Container());
         },
       ),
     );
@@ -57,7 +55,7 @@ void main() {
 
     expect(controller.type, WindowArchetype.regular);
     expect(controller.size, windowSize);
-    expect(controller.view!.viewId, tester.view.viewId);
+    expect(controller.view.viewId, tester.view.viewId);
   });
 
   testWidgets('RegularWindow.onError is called when creation throws an error', (
@@ -105,9 +103,7 @@ void main() {
       wrapWithView: false,
       Builder(
         builder: (BuildContext context) {
-          return WindowingApp(
-            children: <Widget>[RegularWindow(controller: controller, child: Container())],
-          );
+          return RegularWindow(controller: controller, child: Container());
         },
       ),
     );
@@ -135,9 +131,7 @@ void main() {
         wrapWithView: false,
         Builder(
           builder: (BuildContext context) {
-            return WindowingApp(
-              children: <Widget>[RegularWindow(controller: controller, child: Container())],
-            );
+            return RegularWindow(controller: controller, child: Container());
           },
         ),
       );