From 46131eab92be3a19dd26758100dffc6ce162495e Mon Sep 17 00:00:00 2001 From: soer3n Date: Wed, 11 Jun 2025 14:02:16 +0200 Subject: [PATCH 1/2] add docs to explain kv cpu assignment Signed-off-by: soer3n --- .../supported-providers/kubevirt/_index.en.md | 10 ++++++++++ .../supported-providers/kubevirt/_index.en.md | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/content/kubermatic/main/architecture/supported-providers/kubevirt/_index.en.md b/content/kubermatic/main/architecture/supported-providers/kubevirt/_index.en.md index f72b0176a..d4ad27fac 100644 --- a/content/kubermatic/main/architecture/supported-providers/kubevirt/_index.en.md +++ b/content/kubermatic/main/architecture/supported-providers/kubevirt/_index.en.md @@ -108,6 +108,8 @@ We allow to configure: * `External`: the VirtualMachineInstance will be protected by a PDB and `vmi.Status.EvacuationNodeName` will be set on eviction. This is mainly useful for machine-controller which needs a way for VMI's to be blocked from eviction, yet inform machine-controller that eviction has been called on the VMI, so it can handle tearing the VMI down. * `csiDriverOperator` - Contains the KubeVirt CSI Driver Operator configurations, where users can override the default configurations of the csi driver. * `overwriteRegistry`: overwrite the images registry for the csi driver daemonset that runs in the user cluster. +* `enableDedicatedCPUs` (deprecated) - Represents the configuration for virtual machine cpu assignment by using `domain.cpu` when set to `true` or using `resources.requests` and `resources.limits` when set to `false` which is the default +* `usePodResourcesCPU` - Represents the new way of configuring for cpu assignment virtual machine by using `domain.cpu` when set to `false` which is the default or using `resources.requests` and `resources.limits` when set to `true` {{% notice note %}} The `infraStorageClasses` pass names of KubeVirt storage classes that can be used from user clusters. @@ -117,6 +119,14 @@ The `infraStorageClasses` pass names of KubeVirt storage classes that can be use The `namespacedMode` feature is highly experimental and should never be used in production environments. Additionally, enabling this mode in an existing KubeVirt setup utilized by KKP can cause serious issues, such as storage and networking incompatibilities. {{% /notice %}} +{{% notice warning %}} +The `enableDedicatedCPUs` feature takes only effect for new created machines. If you want to use this feature for existing machine deployments you need to rotate the machines after updating this value in seed kubevirt provider spec. +{{% /notice %}} + +{{% notice warning %}} +The `usePodResourcesCPU` feature will replace `enableDedicatedCPUs` flag. In the time of deprecation both are taking effect but the new value will have more priority. When `enableDedicatedCPUs` is set to `false` which is also the default value, you need to set `usePodResourcesCPU` to `true` to keep the same behaviour as before for new created machines. If `enableDedicatedCPUs` was set to `true` nothing needs to be changed. +{{% /notice %}} + Refer to this [document](https://github.com/kubermatic/kubermatic/blob/release/v2.26/docs/zz_generated.seed.ce.yaml#L115) for more details and configuration example. diff --git a/content/kubermatic/v2.27/architecture/supported-providers/kubevirt/_index.en.md b/content/kubermatic/v2.27/architecture/supported-providers/kubevirt/_index.en.md index 56ef5a457..c45bd1ac5 100644 --- a/content/kubermatic/v2.27/architecture/supported-providers/kubevirt/_index.en.md +++ b/content/kubermatic/v2.27/architecture/supported-providers/kubevirt/_index.en.md @@ -108,6 +108,7 @@ We allow to configure: * `External`: the VirtualMachineInstance will be protected by a PDB and `vmi.Status.EvacuationNodeName` will be set on eviction. This is mainly useful for machine-controller which needs a way for VMI's to be blocked from eviction, yet inform machine-controller that eviction has been called on the VMI, so it can handle tearing the VMI down. * `csiDriverOperator` - Contains the KubeVirt CSI Driver Operator configurations, where users can override the default configurations of the csi driver. * `overwriteRegistry`: overwrite the images registry for the csi driver daemonset that runs in the user cluster. +* `enableDedicatedCPUs` - Represents the configuration for virtual machine cpu assignment by using `domain.cpu` when set to `true` or using `resources.requests` and `resources.limits` when set to `false` which is the default {{% notice note %}} The `infraStorageClasses` pass names of KubeVirt storage classes that can be used from user clusters. @@ -117,6 +118,10 @@ The `infraStorageClasses` pass names of KubeVirt storage classes that can be use The `namespacedMode` feature is highly experimental and should never be used in production environments. Additionally, enabling this mode in an existing KubeVirt setup utilized by KKP can cause serious issues, such as storage and networking incompatibilities. {{% /notice %}} +{{% notice warning %}} +The `enableDedicatedCPUs` feature takes only effect for new created machines. If you want to use this feature for existing machine deployments you need to rotate the machines after updating this value in seed kubevirt provider spec. +{{% /notice %}} + Refer to this [document](https://github.com/kubermatic/kubermatic/blob/release/v2.26/docs/zz_generated.seed.ce.yaml#L115) for more details and configuration example. From dd766ab07353e4413aa34cfd423ad73d2dfffe41 Mon Sep 17 00:00:00 2001 From: soer3n Date: Tue, 12 Aug 2025 10:18:49 +0200 Subject: [PATCH 2/2] add kv cpu assignment explanation to kkp 2.28 Signed-off-by: soer3n --- .../supported-providers/kubevirt/_index.en.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/content/kubermatic/v2.28/architecture/supported-providers/kubevirt/_index.en.md b/content/kubermatic/v2.28/architecture/supported-providers/kubevirt/_index.en.md index f72b0176a..d4ad27fac 100644 --- a/content/kubermatic/v2.28/architecture/supported-providers/kubevirt/_index.en.md +++ b/content/kubermatic/v2.28/architecture/supported-providers/kubevirt/_index.en.md @@ -108,6 +108,8 @@ We allow to configure: * `External`: the VirtualMachineInstance will be protected by a PDB and `vmi.Status.EvacuationNodeName` will be set on eviction. This is mainly useful for machine-controller which needs a way for VMI's to be blocked from eviction, yet inform machine-controller that eviction has been called on the VMI, so it can handle tearing the VMI down. * `csiDriverOperator` - Contains the KubeVirt CSI Driver Operator configurations, where users can override the default configurations of the csi driver. * `overwriteRegistry`: overwrite the images registry for the csi driver daemonset that runs in the user cluster. +* `enableDedicatedCPUs` (deprecated) - Represents the configuration for virtual machine cpu assignment by using `domain.cpu` when set to `true` or using `resources.requests` and `resources.limits` when set to `false` which is the default +* `usePodResourcesCPU` - Represents the new way of configuring for cpu assignment virtual machine by using `domain.cpu` when set to `false` which is the default or using `resources.requests` and `resources.limits` when set to `true` {{% notice note %}} The `infraStorageClasses` pass names of KubeVirt storage classes that can be used from user clusters. @@ -117,6 +119,14 @@ The `infraStorageClasses` pass names of KubeVirt storage classes that can be use The `namespacedMode` feature is highly experimental and should never be used in production environments. Additionally, enabling this mode in an existing KubeVirt setup utilized by KKP can cause serious issues, such as storage and networking incompatibilities. {{% /notice %}} +{{% notice warning %}} +The `enableDedicatedCPUs` feature takes only effect for new created machines. If you want to use this feature for existing machine deployments you need to rotate the machines after updating this value in seed kubevirt provider spec. +{{% /notice %}} + +{{% notice warning %}} +The `usePodResourcesCPU` feature will replace `enableDedicatedCPUs` flag. In the time of deprecation both are taking effect but the new value will have more priority. When `enableDedicatedCPUs` is set to `false` which is also the default value, you need to set `usePodResourcesCPU` to `true` to keep the same behaviour as before for new created machines. If `enableDedicatedCPUs` was set to `true` nothing needs to be changed. +{{% /notice %}} + Refer to this [document](https://github.com/kubermatic/kubermatic/blob/release/v2.26/docs/zz_generated.seed.ce.yaml#L115) for more details and configuration example.