Use command as quoted string in CloudAuth

[jnummelin]

We faced a case where gcloud for some reason was installed in path that contains whitespaces. This results in slightly weird (but still perfectly working[1]) kubeconfig:

cmd-path: /Users/auser/exec -l /bin/bash/google-cloud-sdk/bin/gcloud

Now as the CloudAuth uses plain child_process for exec it naturally breaks in this case.

It used to work with 0.10.2 version, but seems 0055a50 broke it when CloudAuth was changed to use plain child_process.

I'd appreciate some pointers and ideas how to make the test case actually portable and without any need to manually first create symlinks. Would it make sense to dynamically create a symlink to echo in some temp dir with whitespaces in the name?

[1] kubectl works perfectly still, so did previous version of JS client as it used execa

[k8s-ci-robot]

Welcome @jnummelin!

It looks like this is your first PR to kubernetes-client/javascript 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/javascript has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[drubin]

Thanks for this!

I remember dealing with something similar with windows pathing previously too #238 it seems like this is a constant problem of back and forth. So your idea of adding a test case for this I believe would solve it hopefully once and for all.

I'd appreciate some pointers and ideas how to make the test case actually portable

We support windows so doing a symlink during the tests might not be the best way to handle this.

But what about potentially trying one of these 2 options(just ideas).

1. Create a nodejs file with a space in it that echo's the arguments back to the user and trying to execute that as part of the test? for example test/echo space.js and trying to use that?
2. Add a test case that validates that the cmd is always quoted before sending it to the function that executes the command.

How does that sound?

[brendandburns]

We use mockfs in a number of places. I'm not sure if spaces work in mockfs correctly though.

[jnummelin]

@drubin Thanks for the ideas. I implemented the test case with option 1, with a small js script named echo space.js. :)

[brendandburns]

/lgtm
/approve

Thanks for the PR!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, jnummelin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brendandburns]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment