Skip to content

Commit e1e0014

Browse files
jiahuifk8s-publishing-bot
authored andcommitted
polish comments of non-enum values.
types: PodConditionType, NodeConditionType Kubernetes-commit: f4cd617b74f7d36d0e181ad8a241016470aeb183
1 parent 5358347 commit e1e0014

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

batch/v1/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ type UncountedTerminatedPods struct {
291291

292292
type JobConditionType string
293293

294-
// These are valid conditions of a job.
294+
// These are built-in conditions of a job.
295295
const (
296296
// JobSuspended means the job has been suspended.
297297
JobSuspended JobConditionType = "Suspended"

core/v1/types.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2636,7 +2636,7 @@ const (
26362636
// PodConditionType is a valid value for PodCondition.Type
26372637
type PodConditionType string
26382638

2639-
// These are valid conditions of pod.
2639+
// These are built-in conditions of pod. An application may use a custom condition not listed here.
26402640
const (
26412641
// ContainersReady indicates whether all containers in the pod are ready.
26422642
ContainersReady PodConditionType = "ContainersReady"
@@ -5055,8 +5055,8 @@ const (
50555055

50565056
type NodeConditionType string
50575057

5058-
// These are valid conditions of node. Currently, we don't have enough information to decide
5059-
// node condition. In the future, we will add more. The proposed set of conditions are:
5058+
// These are valid but not exhaustive conditions of node. A cloud provider may set a condition not listed here.
5059+
// The built-in set of conditions are:
50605060
// NodeReachable, NodeLive, NodeReady, NodeSchedulable, NodeRunnable.
50615061
const (
50625062
// NodeReady means kubelet is healthy and ready to accept pods.
@@ -5093,7 +5093,7 @@ type NodeCondition struct {
50935093

50945094
type NodeAddressType string
50955095

5096-
// These are valid address type of node.
5096+
// These are built-in addresses type of node. A cloud provider may set a type not listed here.
50975097
const (
50985098
// NodeHostName identifies a name of the node. Although every node can be assumed
50995099
// to have a NodeAddress of this type, its exact syntax and semantics are not
@@ -5265,7 +5265,7 @@ const (
52655265

52665266
type NamespaceConditionType string
52675267

5268-
// These are valid conditions of a namespace.
5268+
// These are built-in conditions of a namespace.
52695269
const (
52705270
// NamespaceDeletionDiscoveryFailure contains information about namespace deleter errors during resource discovery.
52715271
NamespaceDeletionDiscoveryFailure NamespaceConditionType = "NamespaceDeletionDiscoveryFailure"
@@ -5753,7 +5753,8 @@ type EventList struct {
57535753
// List holds a list of objects, which may not be known by the server.
57545754
type List metav1.List
57555755

5756-
// LimitType is a type of object that is limited
5756+
// LimitType is a type of object that is limited. It can be Pod, Container, PersistentVolumeClaim or
5757+
// a fully qualified resource name.
57575758
type LimitType string
57585759

57595760
const (

0 commit comments

Comments
 (0)