Skip to content

Commit 1ef5c56

Browse files
committed
scripts: template json safely
Signed-off-by: hasheddan <[email protected]>
1 parent a49231d commit 1ef5c56

File tree

1 file changed

+20
-9
lines changed

1 file changed

+20
-9
lines changed

anago

Lines changed: 20 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1133,15 +1133,26 @@ update_github_release () {
11331133
# post release data
11341134
logecho "$release_verb the $RELEASE_VERSION_PRIME release on github..."
11351135
local changelog_url="$K8S_GITHUB_URL/blob/master/$CHANGELOG_FILE"
1136-
release_id=$($GHCURL $K8S_GITHUB_API/releases$id_suffix --data \
1137-
'{
1138-
"tag_name": "'$RELEASE_VERSION_PRIME'",
1139-
"target_commitish": "'$RELEASE_BRANCH'",
1140-
"name": "'$RELEASE_VERSION_PRIME'",
1141-
"body": "See [kubernetes-announce@](https://groups.google.com/forum/#!forum/kubernetes-announce) and ['$CHANGELOG_FILE']('$changelog_url'#'${RELEASE_VERSION_PRIME//\./}') for details.\n\nSHA256 for `kubernetes.tar.gz`: `'${sha256_hash}'`\n\nSHA512 for `kubernetes.tar.gz`: `'${sha512_hash}'`\n\nAdditional binary downloads are linked in the ['$CHANGELOG_FILE']('$changelog_url'#downloads-for-'${RELEASE_VERSION_PRIME//\./}').",
1142-
"draft": '$draft',
1143-
"prerelease": '$prerelease'
1144-
}' |jq -r '.id')
1136+
query_tmpl='{
1137+
"tag_name" : $tag,
1138+
"target_commitish": $target,
1139+
"name": $name,
1140+
"body": $body,
1141+
"draft": $draft,
1142+
"prerelease": $prerelease
1143+
}'
1144+
body='See [kubernetes-announce@](https://groups.google.com/forum/#!forum/kubernetes-announce) and ['${CHANGELOG_FILE}']('${changelog_url}'#'${RELEASE_VERSION_PRIME//\./}') for details.\n\nSHA256 for `kubernetes.tar.gz`: `'${sha256_hash}'`\n\nSHA512 for `kubernetes.tar.gz`: `'${sha512_hash}'`\n\nAdditional binary downloads are linked in the ['${CHANGELOG_FILE}']('${changelog_url}'#downloads-for-'${RELEASE_VERSION_PRIME//\./}').'
1145+
query_body="$( jq \
1146+
--arg tag "$RELEASE_VERSION_PRIME" \
1147+
--arg target "$RELEASE_BRANCH" \
1148+
--arg name "$RELEASE_VERSION_PRIME" \
1149+
--arg body "$body" \
1150+
--arg draft "$draft" \
1151+
--arg prerelease "$prerelease" \
1152+
-c -n "$query_tmpl" \
1153+
)"
1154+
release_id=$($GHCURL $K8S_GITHUB_API/releases$id_suffix --data "$query_body" \
1155+
|jq -r '.id')
11451156

11461157
# verify it was created
11471158
if [[ -z "$release_id" ]]; then

0 commit comments

Comments
 (0)