Skip to content

Commit 7e4a3ce

Browse files
committed
[krel] changelog: Include CHANGELOG/README.md in master commit logic
Signed-off-by: Stephen Augustus <[email protected]>
1 parent 9b1fcf8 commit 7e4a3ce

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

cmd/krel/cmd/changelog.go

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,10 @@ func htmlChangelogFilename(tag semver.Version) string {
309309
return changelogFilename(tag, "html")
310310
}
311311

312+
func markdownChangelogReadme() string {
313+
return filepath.Join(repoChangelogDir, "README.md")
314+
}
315+
312316
func markdownChangelogFilename(tag semver.Version) string {
313317
return filepath.Join(repoChangelogDir, changelogFilename(tag, "md"))
314318
}
@@ -398,15 +402,24 @@ func lookupRemoteReleaseNotes(branch string) (string, error) {
398402

399403
func commitChanges(repo *git.Repo, branch string, tag semver.Version) error {
400404
// Master branch modifications
401-
filename := markdownChangelogFilename(tag)
402-
logrus.Infof("Adding %s to repository", filename)
403-
if err := repo.Add(filename); err != nil {
404-
return errors.Wrapf(err, "trying to add file %s to repository", filename)
405+
releaseChangelog := markdownChangelogFilename(tag)
406+
changelogReadme := markdownChangelogReadme()
407+
408+
changelogFiles := []string{
409+
releaseChangelog,
410+
changelogReadme,
411+
}
412+
413+
for _, filename := range changelogFiles {
414+
logrus.Infof("Adding %s to repository", filename)
415+
if err := repo.Add(filename); err != nil {
416+
return errors.Wrapf(err, "trying to add file %s to repository", filename)
417+
}
405418
}
406419

407420
logrus.Info("Committing changes to master branch in repository")
408421
if err := repo.Commit(fmt.Sprintf(
409-
"Add %s for %s", filename, util.SemverToTagString(tag),
422+
"CHANGELOG: Update directory for %s release", util.SemverToTagString(tag),
410423
)); err != nil {
411424
return errors.Wrap(err, "committing changes into repository")
412425
}
@@ -423,13 +436,13 @@ func commitChanges(repo *git.Repo, branch string, tag semver.Version) error {
423436
}
424437

425438
logrus.Info("Checking out changelog from master branch")
426-
if err := repo.Checkout(git.Master, filename); err != nil {
427-
return errors.Wrap(err, "checking out master branch changelog")
439+
if err := repo.Checkout(git.Master, releaseChangelog); err != nil {
440+
return errors.Wrap(err, "unable to check out master branch changelog")
428441
}
429442

430443
logrus.Info("Committing changes to release branch in repository")
431444
if err := repo.Commit(fmt.Sprintf(
432-
"Update %s for %s", filename, util.SemverToTagString(tag),
445+
"Update %s for %s", releaseChangelog, util.SemverToTagString(tag),
433446
)); err != nil {
434447
return errors.Wrap(err, "committing changes into repository")
435448
}

0 commit comments

Comments
 (0)