Cleanups on passfail2.py

Author: lambdadog

logger.py

@@ -0,0 +1,2 @@
+import logging
+log = logging.getLogger("Pass/Fail 2 Addon")

passfail2.py

@@ -12,15 +12,14 @@
 # Regards to Dmitry Mikheev for writing the original add-on this was
 # derived from, and the Anki team.
 
+from .logger import log
+
 try:
     from typing import Literal, Callable
-except ImportError as emp:
-    print(emp)
+except ImportError as err:
+    log.debug("Typing import failure: %s", err)
 
-try:
-    from aqt import mw
-except Exception as except1:
-    print("Error Here Pass Fail: " + str(except1))
+from aqt import mw
 
 try:
     from anki.utils import point_version
@@ -32,11 +31,8 @@
         def point_version():
             return int(version.split(".")[-1])
 
-try:
-    from . import button_color
-    from . import configuration_menu
-except Exception as e3:
-    print("Issue with Pass / Fail: 4-" + str(e3))
+from . import button_color
+from . import configuration_menu
 
 from anki.hooks import wrap
 
@@ -54,7 +50,7 @@ def point_version():
 else:
     from anki.lang import _
 
-# Start of Setup for Button Colors
+# Setup config
 toggle_names_textcolors = False
 toggle_bgcolor = False
 again_button_name = "Fail"
@@ -70,33 +66,25 @@ def point_version():
     good_button_name = config['good_button_name']
     again_button_textcolor = config['again_button_textcolor']
     good_button_textcolor = config['good_button_textcolor']
-
-except Exception as e:
-    print("Pass / Fail Minor Error: " + str(e))
-# End of Setup for Button Colors
+except Exception as err:
+    log.warn("Failed to import configuration, using defaults: %s", err)
 
 # Hooks
 def pf2_hook_replace_buttons(
         buttons_tuple, # type: tuple[tuple[int, str], ...]
         reviewer,      # type: Reviewer
         card           # type: Card
 ): # type: (...) -> tuple[tuple[int,str], ...]
-
-    # Use the Updated Version Custom TextColors and Button Names
-    try:
-        if toggle_names_textcolors:
-            return (
-                (1, f"<font color='{again_button_textcolor}'>{again_button_name}</font>"),
-                (reviewer._defaultEase(), f"<font color='{good_button_textcolor}'>{good_button_name}</font>")
-            )
-    except Exception as e1:
-        print("Issue with Pass / Fail TextColor: " + str(e1))
-    # end of Updated Version Custom TextColors and Button Names Addition, or use legacy:
-
-    return (
-        (1, "Fail"),
-        (reviewer._defaultEase(), "Pass")
-    )
+    if toggle_names_textcolors:
+        return (
+            (1, f"<font color='{again_button_textcolor}'>{again_button_name}</font>"),
+            (reviewer._defaultEase(), f"<font color='{good_button_textcolor}'>{good_button_name}</font>")
+        )
+    else:
+        return (
+            (1, "Fail"),
+            (reviewer._defaultEase(), "Pass")
+        )
 
 def pf2_hook_remap_answer_ease(
         ease_tuple, # type: tuple[bool, Literal[1, 2, 3, 4]]
@@ -150,7 +138,8 @@ def pf2_fix_pass_title(
 # Init
 def init():
     version = point_version()
-    configuration_menu.configuration_menu_init()  # Initialize the Anki Plugin Config Qt Menu
+
+    configuration_menu.configuration_menu_init()
 
     # Answer button list
     if version >= 31:
@@ -167,15 +156,9 @@ def init():
     # Show "Shortcut key: 2" rather than "Shortcut key: 3" for "Pass" button
     Reviewer._showEaseButtons = wrap(Reviewer._showEaseButtons, pf2_fix_pass_title, 'after')
 
-    # Use the Edited AnswerButtons, to re-draw Buttons, with Background Color Enabled
-    if toggle_bgcolor and point_version()>=66: # WHAT IS THE CUTOFF?
-        try:
+    # Enable colored buttons
+    if toggle_bgcolor:
+        if point_version() >= 66:
             Reviewer._answerButtons = wrap(Reviewer._answerButtons, button_color.answer_buttons_with_bgcolor, 'after')
-        except Exception as e2:
-            print("Issue with the BG Color part of Pass / Fail: " + str(e2))
-    elif toggle_bgcolor and point_version() < 66:
-        try:
+        else:
             Reviewer._answerButtons = wrap(Reviewer._answerButtons, button_color.answer_buttons_bgcolor_2_1_15, 'after')
-        except Exception as e2:
-            print("Issue with the old BG Color part of Pass / Fail: " + str(e2))
-    # End of usage of Edited AnswerButtons