Skip to content

Milvus unavailability may lead to thread unavailability in the system. #7804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saber-wang opened this issue Apr 25, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@saber-wang
Copy link
Contributor

Bug Description

Milvus unavailability may lead to thread unavailability in the system.

Reproduction

Image

  1. Add the Milvus component with an incorrect URL (e.g., the default value).
  2. Run the tenant.
  3. You can observe that requests never complete.

Expected behavior

Properly complete the request and return an error response.

Who can help?

@italojohnny

It has been confirmed that the issue is caused by this section of code, and it can be mitigated by setting LAGFLOW_PRETTY_LOGS=false.

log_stdout_pretty = os.getenv("LAGFLOW_PRETTY_LOGS", "true").lower() == "true"
if log_stdout_pretty:
logger.configure(
handlers=[
{
"sink": RichHandler(rich_tracebacks=True, markup=True),
"format": log_format,
"level": log_level.upper(),
}
]
)

Operating System

mac os 15

Langflow Version

1.3.3

Python Version

3.12

Screenshot

No response

Flow File

No response

@saber-wang saber-wang added the bug Something isn't working label Apr 25, 2025
Copy link

dosubot bot commented Apr 25, 2025

The issue of thread unavailability when Milvus is unreachable can be mitigated by setting the LAGFLOW_PRETTY_LOGS environment variable to false. This setting affects the logging configuration, where enabling pretty logs (true) can lead to performance issues, especially in high-load scenarios or when external dependencies like Milvus are not available. By setting LAGFLOW_PRETTY_LOGS=false, the system uses a more performance-oriented logging format, which helps prevent requests from hanging indefinitely when Milvus is unreachable. This adjustment is particularly useful in production environments to ensure smoother operation and better resource management.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant