fix: remove php 8.4 deprecation notices

Author: lindyhopchris

.github/workflows/tests.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
         laravel: [11]
 
     steps:

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec
 
 ## Unreleased
 
+### Fixed
+
+- Remove deprecation notices in PHP 8.4.
+
 ## [4.1.1] - 2024-06-20
 
 ### Fixed

composer.json

@@ -27,7 +27,7 @@
         "ext-json": "*",
         "illuminate/contracts": "^11.0",
         "illuminate/support": "^11.0",
-        "laravel-json-api/core": "^4.0"
+        "laravel-json-api/core": "^4.3.2"
     },
     "require-dev": {
         "orchestra/testbench": "^9.0",
@@ -53,7 +53,7 @@
             ]
         }
     },
-    "minimum-stability": "stable",
+    "minimum-stability": "dev",
     "prefer-stable": true,
     "config": {
         "sort-packages": true

phpunit.xml

@@ -13,6 +13,7 @@
          failOnWarning="true"
          failOnDeprecation="true"
          failOnNotice="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
 >
     <coverage/>
     <testsuites>

src/JsonApiValidation.php

@@ -66,7 +66,7 @@ public static function showValidatorFailures(): self
      * @param string|null $path
      * @return string
      */
-    public static function translationKeyForRule($rule, string $path = null): string
+    public static function translationKeyForRule($rule, ?string $path = null): string
     {
         $name = Str::snake(class_basename($rule));
 
@@ -80,7 +80,7 @@ public static function translationKeyForRule($rule, string $path = null): string
      * @param string|null $path
      * @return string
      */
-    public static function qualifyTranslationKey(string $key, string $path = null): string
+    public static function qualifyTranslationKey(string $key, ?string $path = null): string
     {
         $namespace = self::$translationNamespace;
         $qualified = "{$namespace}::validation.{$key}";

src/Rule.php

@@ -128,7 +128,7 @@ public static function dateTime(): DateTimeIso8601
      * @param array|null $allowed
      * @return AllowedFieldSets
      */
-    public static function fieldSets(array $allowed = null): AllowedFieldSets
+    public static function fieldSets(?array $allowed = null): AllowedFieldSets
     {
         if (is_null($allowed)) {
             return AllowedFieldSets::make(
@@ -217,7 +217,7 @@ public static function integer(): JsonNumber
      * @param string|null $name
      * @return ParameterNotSupported
      */
-    public static function notSupported(string $name = null): ParameterNotSupported
+    public static function notSupported(?string $name = null): ParameterNotSupported
     {
         return new ParameterNotSupported($name);
     }

src/Rules/AllowedFieldSets.php

@@ -68,7 +68,7 @@ public function __construct(iterable $allowed = [])
      *      the allowed fields, empty array for none allowed, or null for all allowed.
      * @return $this
      */
-    public function allow(string $resourceType, array $fields = null): self
+    public function allow(string $resourceType, ?array $fields = null): self
     {
         $this->allowed[$resourceType] = $fields;
 

src/Rules/ParameterNotSupported.php

@@ -25,9 +25,9 @@ class ParameterNotSupported implements Rule
     /**
      * DisallowedParameter constructor.
      *
-     * @param string $name
+     * @param string|null $name
      */
-    public function __construct(string $name = null)
+    public function __construct(?string $name = null)
     {
         $this->name = $name;
     }

src/Translator.php

@@ -46,7 +46,7 @@ public function __construct(TranslatorContract $translator)
      *      rule failure details
      * @return Error
      */
-    public function invalid(string $pointer, string $detail = null, array $failed = []): Error
+    public function invalid(string $pointer, ?string $detail = null, array $failed = []): Error
     {
         return Error::make()
             ->setStatus(422)
@@ -67,7 +67,7 @@ public function invalid(string $pointer, string $detail = null, array $failed =
      *      rule failure details
      * @return Error
      */
-    public function invalidResource(string $pointer, string $detail = null, array $failed = []): Error
+    public function invalidResource(string $pointer, ?string $detail = null, array $failed = []): Error
     {
         return Error::make()
             ->setStatus(422)
@@ -88,7 +88,7 @@ public function invalidResource(string $pointer, string $detail = null, array $f
      *      rule failure details.
      * @return Error
      */
-    public function invalidQueryParameter(string $param, string $detail = null, array $failed = []): Error
+    public function invalidQueryParameter(string $param, ?string $detail = null, array $failed = []): Error
     {
         return Error::make()
             ->setStatus(400)
@@ -106,7 +106,7 @@ public function invalidQueryParameter(string $param, string $detail = null, arra
      *      the validation message (already translated).
      * @return Error
      */
-    public function invalidDeleteRequest(string $detail = null): Error
+    public function invalidDeleteRequest(?string $detail = null): Error
     {
         return Error::make()
             ->setStatus(422)