Implement real-time factories within HasFactory

Author: jbrooksuk

src/Illuminate/Database/Eloquent/Factories/Factory.php

@@ -813,11 +813,17 @@ public static function useNamespace(string $namespace)
      *
      * @param  class-string<\Illuminate\Database\Eloquent\Model>  $modelName
      * @return \Illuminate\Database\Eloquent\Factories\Factory
+     *
+     * @throws \Illuminate\Database\Eloquent\Factories\FactoryNotFoundException
      */
     public static function factoryForModel(string $modelName)
     {
         $factory = static::resolveFactoryName($modelName);
 
+        if (! class_exists($factory)) {
+            throw new FactoryNotFoundException($factory);
+        }
+
         return $factory::new();
     }
 
@@ -906,10 +912,14 @@ public function __call($method, $parameters)
 
         $relatedModel = get_class($this->newModel()->{$relationship}()->getRelated());
 
-        if (method_exists($relatedModel, 'newFactory')) {
-            $factory = $relatedModel::newFactory() ?? static::factoryForModel($relatedModel);
-        } else {
-            $factory = static::factoryForModel($relatedModel);
+        try {
+            if (method_exists($relatedModel, 'newFactory')) {
+                $factory = $relatedModel::newFactory() ?? static::factoryForModel($relatedModel);
+            } else {
+                $factory = static::factoryForModel($relatedModel);
+            }
+        } catch (FactoryNotFoundException $e) {
+            $factory = $relatedModel::newRealTimeFactory();
         }
 
         if (str_starts_with($method, 'for')) {

src/Illuminate/Database/Eloquent/Factories/FactoryNotFoundException.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace Illuminate\Database\Eloquent\Factories;
+
+use RuntimeException;
+
+class FactoryNotFoundException extends RuntimeException
+{
+    /**
+     * The factory that was not found.
+     *
+     * @var string
+     */
+    public $factory;
+
+    /**
+     * Create a new exception instance.
+     *
+     * @param  string  $factory
+     * @return static
+     */
+    public function __construct($factory)
+    {
+        parent::__construct("Call to undefined factory [{$factory}]");
+
+        $this->factory = $factory;
+    }
+}

src/Illuminate/Database/Eloquent/Factories/HasFactory.php

@@ -13,13 +13,29 @@ trait HasFactory
      */
     public static function factory($count = null, $state = [])
     {
-        $factory = static::newFactory() ?: Factory::factoryForModel(get_called_class());
+        try {
+            $factory = static::newFactory() ?: Factory::factoryForModel(get_called_class());
+        } catch (FactoryNotFoundException $e) {
+            $factory = static::newRealTimeFactory();
+        }
 
         return $factory
                     ->count(is_numeric($count) ? $count : null)
                     ->state(is_callable($count) || is_array($count) ? $count : $state);
     }
 
+    /**
+     * Create a new factory instance for the model.
+     *
+     * @return \Illuminate\Database\Eloquent\Factories\Factory<static>
+     */
+    protected static function newRealTimeFactory()
+    {
+        return (new RealTimeFactory)
+            ->forModel(get_called_class())
+            ->configure();
+    }
+
     /**
      * Create a new factory instance for the model.
      *

src/Illuminate/Database/Eloquent/Factories/HasRealTimeFactory.php

@@ -14,7 +14,7 @@
 use Illuminate\Database\Eloquent\Casts\AsEncryptedCollection;
 use Illuminate\Database\Eloquent\Casts\AsEnumCollection;
 use Illuminate\Database\Eloquent\Factories\Factory;
-use Illuminate\Database\Eloquent\Factories\HasRealTimeFactory;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model as Eloquent;
 use Illuminate\Database\QueryException;
 use Illuminate\Encryption\Encrypter;
@@ -581,7 +581,7 @@ public function testItCanHandleManyToManyPolymorphicRelationships()
 
     public function testItCanBeUsedToDefineARelationWithinAFactory()
     {
-        $post = PostFactory::new()->create();
+        $post = PostDummyFactory::new()->create();
 
         $this->assertNotNull($post->user);
     }
@@ -598,7 +598,7 @@ public function testRealTimeFactoriesCannotBeInstantiatedWithNew()
         $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Real-time factories cannot be instantiated with new()');
 
-        Post::factory()->times(3);
+        User::factory()->times(3);
     }
 
     public function testIgnoresPrimaryAndForeignKeysFromDefinition()
@@ -612,7 +612,7 @@ public function testIgnoresPrimaryAndForeignKeysFromDefinition()
 
 class Cast extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     protected $casts = [
         'array_column' => 'array',
@@ -648,27 +648,27 @@ class Cast extends Eloquent
 
 class Type extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 }
 
 class Nullable extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 }
 
 class Guess extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 }
 
 class Key extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 }
 
 class User extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     public function posts()
     {
@@ -685,7 +685,7 @@ public function roles()
 
 class Post extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     protected $casts = [
         'published' => 'boolean',
@@ -711,7 +711,7 @@ public function tags()
 
 class Role extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     public function users()
     {
@@ -723,7 +723,7 @@ public function users()
 
 class Comment extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     public function commentable()
     {
@@ -733,7 +733,7 @@ public function commentable()
 
 class Tag extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 
     public function posts()
     {
@@ -743,10 +743,10 @@ public function posts()
 
 class ReservedWord extends Eloquent
 {
-    use HasRealTimeFactory;
+    use HasFactory;
 }
 
-class PostFactory extends Factory
+class PostDummyFactory extends Factory
 {
     protected $model = Post::class;