[7.x] Fixes database offset value with non numbers (#39656)

* Fixes database offset value with non numbers (#37164)

* Apply fixes from StyleCI

Co-authored-by: Nuno Maduro <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>

Author: 3 people

src/Illuminate/Console/Events/ScheduledTaskFailed.php

@@ -24,8 +24,8 @@ class ScheduledTaskFailed
     /**
      * Create a new event instance.
      *
-     * @param \Illuminate\Console\Scheduling\Event $task
-     * @param \Throwable $exception
+     * @param  \Illuminate\Console\Scheduling\Event  $task
+     * @param  \Throwable  $exception
      */
     public function __construct(Event $task, Throwable $exception)
     {

src/Illuminate/Console/Scheduling/Event.php

@@ -579,7 +579,7 @@ protected function pingCallback($url)
         return function (Container $container, HttpClient $http) use ($url) {
             try {
                 $http->request('GET', $url);
-            } catch (ClientExceptionInterface | TransferException $e) {
+            } catch (ClientExceptionInterface|TransferException $e) {
                 $container->make(ExceptionHandler::class)->report($e);
             }
         };

src/Illuminate/Container/Container.php

@@ -1112,7 +1112,6 @@ protected function fireAfterResolvingCallbacks($abstract, $object)
      * @param  string  $abstract
      * @param  object  $object
      * @param  array  $callbacksPerType
-     *
      * @return array
      */
     protected function getCallbacksForType($abstract, $object, array $callbacksPerType)

src/Illuminate/Contracts/Foundation/Application.php

@@ -24,23 +24,23 @@ public function basePath($path = '');
     /**
      * Get the path to the bootstrap directory.
      *
-     * @param  string  $path Optionally, a path to append to the bootstrap path
+     * @param  string  $path  Optionally, a path to append to the bootstrap path
      * @return string
      */
     public function bootstrapPath($path = '');
 
     /**
      * Get the path to the application configuration files.
      *
-     * @param  string  $path Optionally, a path to append to the config path
+     * @param  string  $path  Optionally, a path to append to the config path
      * @return string
      */
     public function configPath($path = '');
 
     /**
      * Get the path to the database directory.
      *
-     * @param  string  $path Optionally, a path to append to the database path
+     * @param  string  $path  Optionally, a path to append to the database path
      * @return string
      */
     public function databasePath($path = '');

src/Illuminate/Database/Eloquent/Relations/BelongsTo.php

@@ -54,7 +54,6 @@ class BelongsTo extends Relation
      * @param  string  $foreignKey
      * @param  string  $ownerKey
      * @param  string  $relationName
-     *
      * @return void
      */
     public function __construct(Builder $query, Model $child, $foreignKey, $ownerKey, $relationName)

src/Illuminate/Database/Query/Builder.php

@@ -2022,7 +2022,7 @@ public function offset($value)
     {
         $property = $this->unions ? 'unionOffset' : 'offset';
 
-        $this->$property = max(0, $value);
+        $this->$property = max(0, (int) $value);
 
         return $this;
     }

src/Illuminate/Database/Schema/Grammars/SQLiteGrammar.php

@@ -625,6 +625,7 @@ protected function typeDateTime(Fluent $column)
      * Create the column definition for a date-time (with time zone) type.
      *
      * Note: "SQLite does not have a storage class set aside for storing dates and/or times."
+     *
      * @link https://www.sqlite.org/datatype3.html
      *
      * @param  \Illuminate\Support\Fluent  $column

src/Illuminate/Foundation/Application.php

@@ -344,7 +344,7 @@ public function useAppPath($path)
     /**
      * Get the base path of the Laravel installation.
      *
-     * @param  string  $path Optionally, a path to append to the base path
+     * @param  string  $path  Optionally, a path to append to the base path
      * @return string
      */
     public function basePath($path = '')
@@ -355,7 +355,7 @@ public function basePath($path = '')
     /**
      * Get the path to the bootstrap directory.
      *
-     * @param  string  $path Optionally, a path to append to the bootstrap path
+     * @param  string  $path  Optionally, a path to append to the bootstrap path
      * @return string
      */
     public function bootstrapPath($path = '')
@@ -366,7 +366,7 @@ public function bootstrapPath($path = '')
     /**
      * Get the path to the application configuration files.
      *
-     * @param  string  $path Optionally, a path to append to the config path
+     * @param  string  $path  Optionally, a path to append to the config path
      * @return string
      */
     public function configPath($path = '')
@@ -377,7 +377,7 @@ public function configPath($path = '')
     /**
      * Get the path to the database directory.
      *
-     * @param  string  $path Optionally, a path to append to the database path
+     * @param  string  $path  Optionally, a path to append to the database path
      * @return string
      */
     public function databasePath($path = '')

src/Illuminate/Foundation/Testing/Concerns/InteractsWithExceptionHandling.php

@@ -64,7 +64,8 @@ protected function withoutExceptionHandling(array $except = [])
             $this->originalExceptionHandler = app(ExceptionHandler::class);
         }
 
-        $this->app->instance(ExceptionHandler::class, new class($this->originalExceptionHandler, $except) implements ExceptionHandler {
+        $this->app->instance(ExceptionHandler::class, new class($this->originalExceptionHandler, $except) implements ExceptionHandler
+        {
             protected $except;
             protected $originalHandler;
 

src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php

@@ -142,7 +142,8 @@ public function withoutMiddleware($middleware = null)
         }
 
         foreach ((array) $middleware as $abstract) {
-            $this->app->instance($abstract, new class {
+            $this->app->instance($abstract, new class
+            {
                 public function handle($request, $next)
                 {
                     return $next($request);

src/Illuminate/Log/LogManager.php

@@ -494,7 +494,6 @@ public function forgetChannel($driver = null)
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function emergency($message, array $context = [])
@@ -510,7 +509,6 @@ public function emergency($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function alert($message, array $context = [])
@@ -525,7 +523,6 @@ public function alert($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function critical($message, array $context = [])
@@ -539,7 +536,6 @@ public function critical($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function error($message, array $context = [])
@@ -555,7 +551,6 @@ public function error($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function warning($message, array $context = [])
@@ -568,7 +563,6 @@ public function warning($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function notice($message, array $context = [])
@@ -583,7 +577,6 @@ public function notice($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function info($message, array $context = [])
@@ -596,7 +589,6 @@ public function info($message, array $context = [])
      *
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function debug($message, array $context = [])
@@ -610,7 +602,6 @@ public function debug($message, array $context = [])
      * @param  mixed  $level
      * @param  string  $message
      * @param  array  $context
-     *
      * @return void
      */
     public function log($level, $message, array $context = [])

src/Illuminate/Mail/PendingMail.php

@@ -126,6 +126,7 @@ public function send(MailableContract $mailable)
      *
      * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
      * @return mixed
+     *
      * @deprecated Use send() instead.
      */
     public function sendNow(MailableContract $mailable)

src/Illuminate/Pagination/LengthAwarePaginator.php

@@ -34,7 +34,7 @@ class LengthAwarePaginator extends AbstractPaginator implements Arrayable, Array
      * @param  int  $total
      * @param  int  $perPage
      * @param  int|null  $currentPage
-     * @param  array  $options (path, query, fragment, pageName)
+     * @param  array  $options  (path, query, fragment, pageName)
      * @return void
      */
     public function __construct($items, $total, $perPage, $currentPage = null, array $options = [])

src/Illuminate/Pagination/Paginator.php

@@ -26,7 +26,7 @@ class Paginator extends AbstractPaginator implements Arrayable, ArrayAccess, Cou
      * @param  mixed  $items
      * @param  int  $perPage
      * @param  int|null  $currentPage
-     * @param  array  $options (path, query, fragment, pageName)
+     * @param  array  $options  (path, query, fragment, pageName)
      * @return void
      */
     public function __construct($items, $perPage, $currentPage = null, array $options = [])

src/Illuminate/Queue/SerializableClosure.php

@@ -11,7 +11,7 @@ class SerializableClosure extends OpisSerializableClosure
     /**
      * Transform the use variables before serialization.
      *
-     * @param  array  $data The Closure's use variables
+     * @param  array  $data  The Closure's use variables
      * @return array
      */
     protected function transformUseVariables($data)
@@ -26,7 +26,7 @@ protected function transformUseVariables($data)
     /**
      * Resolve the use variables after unserialization.
      *
-     * @param  array  $data The Closure's transformed use variables
+     * @param  array  $data  The Closure's transformed use variables
      * @return array
      */
     protected function resolveUseVariables($data)

src/Illuminate/Routing/CompiledRouteCollection.php

@@ -121,7 +121,7 @@ public function match(Request $request)
             if ($result = $matcher->matchRequest($trimmedRequest)) {
                 $route = $this->getByName($result['_route']);
             }
-        } catch (ResourceNotFoundException | MethodNotAllowedException $e) {
+        } catch (ResourceNotFoundException|MethodNotAllowedException $e) {
             try {
                 return $this->routes->match($request);
             } catch (NotFoundHttpException $e) {
@@ -136,7 +136,7 @@ public function match(Request $request)
                 if (! $dynamicRoute->isFallback) {
                     $route = $dynamicRoute;
                 }
-            } catch (NotFoundHttpException | MethodNotAllowedHttpException $e) {
+            } catch (NotFoundHttpException|MethodNotAllowedHttpException $e) {
                 //
             }
         }

src/Illuminate/Support/Collection.php

@@ -808,7 +808,7 @@ public function prepend($value, $key = null)
     /**
      * Push one or more items onto the end of the collection.
      *
-     * @param  mixed  $values [optional]
+     * @param  mixed  $values  [optional]
      * @return $this
      */
     public function push(...$values)

src/Illuminate/Support/Testing/Fakes/PendingMailFake.php

@@ -34,6 +34,7 @@ public function send(Mailable $mailable)
      *
      * @param  \Illuminate\Contracts\Mail\Mailable  $mailable
      * @return mixed
+     *
      * @deprecated Use send() instead.
      */
     public function sendNow(Mailable $mailable)

src/Illuminate/Support/Traits/ForwardsCalls.php

@@ -21,7 +21,7 @@ protected function forwardCallTo($object, $method, $parameters)
     {
         try {
             return $object->{$method}(...$parameters);
-        } catch (Error | BadMethodCallException $e) {
+        } catch (Error|BadMethodCallException $e) {
             $pattern = '~^Call to undefined method (?P<class>[^:]+)::(?P<method>[^\(]+)\(\)$~';
 
             if (! preg_match($pattern, $e->getMessage(), $matches)) {

src/Illuminate/Testing/Constraints/ArraySubset.php

@@ -91,9 +91,9 @@ public function evaluate($other, string $description = '', bool $returnResult =
         /**
          * Returns a string representation of the constraint.
          *
-         * @throws \SebastianBergmann\RecursionContext\InvalidArgumentException
-         *
          * @return string
+         *
+         * @throws \SebastianBergmann\RecursionContext\InvalidArgumentException
          */
         public function toString(): string
         {
@@ -224,9 +224,9 @@ public function evaluate($other, string $description = '', bool $returnResult =
         /**
          * Returns a string representation of the constraint.
          *
-         * @throws \SebastianBergmann\RecursionContext\InvalidArgumentException
-         *
          * @return string
+         *
+         * @throws \SebastianBergmann\RecursionContext\InvalidArgumentException
          */
         public function toString(): string
         {

src/Illuminate/Validation/Concerns/ValidatesAttributes.php

@@ -1918,7 +1918,6 @@ protected function isSameType($first, $second)
      *
      * @param  string  $attribute
      * @param  string  $rule
-     *
      * @return void
      */
     protected function shouldBeNumeric($attribute, $rule)

src/Illuminate/Validation/Validator.php

@@ -430,7 +430,6 @@ protected function shouldBeExcluded($attribute)
      * Remove the given attribute.
      *
      * @param  string  $attribute
-     *
      * @return void
      */
     protected function removeAttribute($attribute)

tests/Auth/AuthenticatableTest.php

@@ -23,7 +23,8 @@ public function testItReturnsStringAsRememberTokenWhenItWasSetToTrue()
 
     public function testItReturnsNullWhenRememberTokenNameWasSetToEmpty()
     {
-        $user = new class extends User {
+        $user = new class extends User
+        {
             public function getRememberTokenName()
             {
                 return '';

tests/Cache/CacheRepositoryTest.php

@@ -223,6 +223,7 @@ public function dataProviderTestGetSeconds()
 
     /**
      * @dataProvider dataProviderTestGetSeconds
+     *
      * @param  mixed  $duration
      */
     public function testGetSeconds($duration)

tests/Console/CommandTest.php

@@ -49,7 +49,8 @@ public function testCallingClassCommandResolveCommandViaApplicationResolution()
 
     public function testGettingCommandArgumentsAndOptionsByClass()
     {
-        $command = new class extends Command {
+        $command = new class extends Command
+        {
             public function handle()
             {
             }

tests/Database/DatabaseEloquentCollectionTest.php

@@ -465,17 +465,19 @@ public function testQueueableCollectionImplementationThrowsExceptionOnMultipleMo
     public function testQueueableRelationshipsReturnsOnlyRelationsCommonToAllModels()
     {
         // This is needed to prevent loading non-existing relationships on polymorphic model collections (#26126)
-        $c = new Collection([new class {
+        $c = new Collection([new class
+        {
             public function getQueueableRelations()
             {
                 return ['user'];
             }
-        }, new class {
+        }, new class
+        {
             public function getQueueableRelations()
             {
                 return ['user', 'comments'];
             }
-        }]);
+        }, ]);
 
         $this->assertEquals(['user'], $c->getQueueableRelations());
     }