Merge pull request #58 from laravelcm/code-analyses

Code analyses

Author: mckenziearts

.github/workflows/php-cs-fixer.yml

@@ -43,6 +43,7 @@ Homestead.json
 Homestead.yaml
 .phpstorm.meta.php
 _ide_helper.php
+_ide_helper_models.php
 
 # OSX
 #

.gitignore

@@ -16,8 +16,9 @@ class CreateNewUser implements CreatesNewUsers
     /**
      * Validate and create a newly registered user.
      *
-     * @param array $input
+     * @param  array  $input<string, string>
      * @return \App\Models\User
+     *
      * @throws \Illuminate\Validation\ValidationException
      */
     public function create(array $input): User

.php-cs-fixer.php

@@ -9,7 +9,7 @@ trait PasswordValidationRules
     /**
      * Get the validation rules used to validate passwords.
      *
-     * @return array
+     * @return array<int, \Illuminate\Validation\Rules\Password|string>
      */
     protected function passwordRules(): array
     {

app/Actions/Fortify/CreateNewUser.php

@@ -13,9 +13,10 @@ class ResetUserPassword implements ResetsUserPasswords
     /**
      * Validate and reset the user's forgotten password.
      *
-     * @param mixed $user
-     * @param array $input
+     * @param  mixed  $user
+     * @param  array  $input<string string>
      * @return void
+     *
      * @throws \Illuminate\Validation\ValidationException
      */
     public function reset($user, array $input)

app/Actions/Fortify/PasswordValidationRules.php

@@ -13,9 +13,10 @@ class UpdateUserPassword implements UpdatesUserPasswords
     /**
      * Validate and update the user's password.
      *
-     * @param mixed $user
-     * @param array $input
+     * @param  mixed  $user
+     * @param  array  $input
      * @return void
+     *
      * @throws \Illuminate\Validation\ValidationException
      */
     public function update($user, array $input)
@@ -24,7 +25,7 @@ public function update($user, array $input)
             'current_password' => ['required', 'string'],
             'password' => $this->passwordRules(),
         ])->after(function ($validator) use ($user, $input) {
-            if (!isset($input['current_password']) || !Hash::check($input['current_password'], $user->password)) {
+            if (! isset($input['current_password']) || ! Hash::check($input['current_password'], $user->password)) {
                 $validator->errors()->add('current_password', __('Le mot de passe fourni ne correspond pas à votre mot de passe actuel.'));
             }
         })->validateWithBag('updatePassword');

app/Actions/Fortify/ResetUserPassword.php

@@ -12,9 +12,10 @@ class UpdateUserProfileInformation implements UpdatesUserProfileInformation
     /**
      * Validate and update the given user's profile information.
      *
-     * @param mixed $user
-     * @param array $input
+     * @param  mixed  $user
+     * @param  array  $input<string, string>
      * @return void
+     *
      * @throws \Illuminate\Validation\ValidationException
      */
     public function update($user, array $input)

app/Actions/Fortify/UpdateUserPassword.php

@@ -12,16 +12,18 @@ class DeleteOldUnverifiedUsers extends Command
 
     protected $description = 'Removed all unverified users.';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Deleting old unverified users...');
 
         $query = User::query()
             ->whereNull('email_verified_at')
             ->where('created_at', '<', now()->subDays(10));
 
-        if ($query->get()->isNotEmpty()) {
-            foreach ($query->get() as $user) {
+        $users = $query->get();
+
+        if ($users->isNotEmpty()) {
+            foreach ($users as $user) {
                 $user->notify((new SendEMailToDeletedUser())->delay(now()->addMinutes(5)));
             }
         }

app/Actions/Fortify/UpdateUserProfileInformation.php

@@ -2,27 +2,18 @@
 
 namespace App\Console\Commands;
 
+use App\Models\User;
 use Illuminate\Console\Command;
 use Illuminate\Database\QueryException;
 use Illuminate\Support\Facades\Hash;
 
 class CreateAdminUser extends Command
 {
-    /**
-     * The name and signature of the console command.
-     *
-     * @var string
-     */
     protected $signature = 'lcm:admin';
 
-    /**
-     * The console command description.
-     *
-     * @var string
-     */
     protected $description = 'Create user with admin role and all permissions.';
 
-    public function handle()
+    public function handle(): void
     {
         $this->info('Create Admin User.');
         $this->createUser();
@@ -51,10 +42,9 @@ protected function createUser(): void
             'password' => Hash::make($password),
             'email_verified_at' => now()->toDateTimeString(),
         ];
-        $model = config('auth.providers.users.model');
 
         try {
-            $user = tap((new $model)->forceFill($userData))->save();
+            $user = User::query()->create($userData);
 
             $user->assignRole('admin');
         } catch (\Exception | QueryException $e) {