From 562b8b1cd522e58a049d0609e5674bfa633119a9 Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Tue, 29 Jul 2025 14:34:32 +0000 Subject: [PATCH] fix: Remove deprecated track generation event --- .../__tests__/LDAIConfigTrackerImpl.test.ts | 92 +------------------ .../server-ai/src/LDAIConfigTrackerImpl.ts | 2 - 2 files changed, 1 insertion(+), 93 deletions(-) diff --git a/packages/sdk/server-ai/__tests__/LDAIConfigTrackerImpl.test.ts b/packages/sdk/server-ai/__tests__/LDAIConfigTrackerImpl.test.ts index 9dd28574c..6b292e1ba 100644 --- a/packages/sdk/server-ai/__tests__/LDAIConfigTrackerImpl.test.ts +++ b/packages/sdk/server-ai/__tests__/LDAIConfigTrackerImpl.test.ts @@ -123,13 +123,6 @@ it('tracks success', () => { ); tracker.trackSuccess(); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -167,13 +160,6 @@ it('tracks OpenAI usage', async () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -234,13 +220,6 @@ it('tracks error when OpenAI metrics function throws', async () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, @@ -281,13 +260,6 @@ it('tracks Bedrock conversation with successful response', () => { tracker.trackBedrockConverseMetrics(response); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -346,13 +318,7 @@ it('tracks Bedrock conversation with error response', () => { tracker.trackBedrockConverseMetrics(response); - expect(mockTrack).toHaveBeenCalledTimes(2); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); + expect(mockTrack).toHaveBeenCalledTimes(1); expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', @@ -399,13 +365,6 @@ describe('Vercel AI SDK generateText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -466,13 +425,6 @@ describe('Vercel AI SDK generateText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, @@ -532,13 +484,6 @@ describe('Vercel AI SDK streamText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -599,13 +544,6 @@ describe('Vercel AI SDK streamText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, @@ -644,13 +582,6 @@ describe('Vercel AI SDK streamText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, @@ -689,13 +620,6 @@ describe('Vercel AI SDK streamText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, @@ -735,13 +659,6 @@ describe('Vercel AI SDK streamText', () => { 1000, ); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:success', testContext, @@ -926,13 +843,6 @@ it('tracks error', () => { ); tracker.trackError(); - expect(mockTrack).toHaveBeenCalledWith( - '$ld:ai:generation', - testContext, - { configKey, variationKey, version }, - 1, - ); - expect(mockTrack).toHaveBeenCalledWith( '$ld:ai:generation:error', testContext, diff --git a/packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts b/packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts index 73c4bdfbd..6dd21bb51 100644 --- a/packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts +++ b/packages/sdk/server-ai/src/LDAIConfigTrackerImpl.ts @@ -69,13 +69,11 @@ export class LDAIConfigTrackerImpl implements LDAIConfigTracker { trackSuccess(): void { this._trackedMetrics.success = true; - this._ldClient.track('$ld:ai:generation', this._context, this._getTrackData(), 1); this._ldClient.track('$ld:ai:generation:success', this._context, this._getTrackData(), 1); } trackError(): void { this._trackedMetrics.success = false; - this._ldClient.track('$ld:ai:generation', this._context, this._getTrackData(), 1); this._ldClient.track('$ld:ai:generation:error', this._context, this._getTrackData(), 1); }