Skip to content

Conversation

pkaeding
Copy link

@pkaeding pkaeding commented Sep 11, 2025

Summary

Updates the dependency-scan GitHub Actions workflow to use the newer launchdarkly/common-actions format instead of the legacy launchdarkly/gh-actions format as part of security initiative SEC-7263.

Key changes:

  • Migrated from launchdarkly/gh-actions to launchdarkly/common-actions
  • Split workflow into separate SBOM generation and policy evaluation jobs
  • Removed Go language scanning (keeping only Node.js)
  • Updated to use runs-on runner pattern for better performance
  • Added push trigger for main branch
  • Added proper artifacts pattern configuration

Testing approaches

The workflow changes should be validated by:

  • Verifying the workflow runs successfully on this PR
  • Confirming SBOM artifacts are generated correctly
  • Ensuring policy evaluation step can access the generated artifacts

Review checklist

  • Verify language scope: Confirm this repository only uses Node.js and doesn't require Go dependency scanning
  • Test workflow structure: Ensure the two-job workflow with dependencies functions correctly
  • Check artifacts pattern: Verify bom-* pattern matches what the generate-sbom action produces
  • Confirm trigger behavior: Validate that adding push trigger for main branch is desired

Link to Devin run: https://app.devin.ai/sessions/434bb14b7bac4d81b9979b88965be92b
Requested by: Patrick Kaeding (@pkaeding)


Related Jira issue: SEC-7263: Investigate impact of compromised NPM packages: debug and chalk

Replace launchdarkly/gh-actions with launchdarkly/common-actions for SEC-7263.
Update to use runs-on runner pattern and add proper artifacts configuration.

Co-Authored-By: Patrick Kaeding <[email protected]>
@pkaeding pkaeding requested a review from a team as a code owner September 11, 2025 13:31
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

changeset-bot bot commented Sep 11, 2025

⚠️ No Changeset found

Latest commit: 82aa2cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration bot changed the title [SEC-7263] Update dependency-scan workflow to use common-actions ci: [SEC-7263] Update dependency-scan workflow to use common-actions Sep 11, 2025
Copy link
Contributor

github-actions bot commented Sep 11, 2025

Size Change: 0 B

Total Size: 530 kB

ℹ️ View Unchanged
Filename Size
apps/vscode/dist/client.js 111 kB
apps/vscode/dist/server.js 261 kB
packages/box/dist/index.es.js 7.26 kB
packages/box/dist/index.js 7.82 kB
packages/box/dist/style.css 2.67 kB
packages/button/dist/index.es.js 1.89 kB
packages/button/dist/index.js 2.32 kB
packages/button/dist/style.css 3 kB
packages/components/dist/index.es.js 19 kB
packages/components/dist/index.js 19.9 kB
packages/components/dist/style.css 8.43 kB
packages/core/dist/index.es.js 512 B
packages/core/dist/index.js 1.27 kB
packages/drawer/dist/index.es.js 1.76 kB
packages/drawer/dist/index.js 2.22 kB
packages/drawer/dist/style.css 497 B
packages/dropdown/dist/index.es.js 1.15 kB
packages/dropdown/dist/index.js 1.59 kB
packages/filter/dist/index.es.js 2.23 kB
packages/filter/dist/index.js 2.68 kB
packages/filter/dist/style.css 881 B
packages/focus-trap/dist/index.es.js 418 B
packages/focus-trap/dist/index.js 852 B
packages/form/dist/index.es.js 4.25 kB
packages/form/dist/index.js 4.73 kB
packages/form/dist/style.css 2.21 kB
packages/icons/dist/index.es.js 1.3 kB
packages/icons/dist/index.js 1.73 kB
packages/icons/dist/style.css 532 B
packages/menu/dist/index.es.js 3.69 kB
packages/menu/dist/index.js 4.16 kB
packages/menu/dist/style.css 872 B
packages/modal/dist/index.es.js 3.08 kB
packages/modal/dist/index.js 3.55 kB
packages/modal/dist/style.css 898 B
packages/navigation/dist/index.es.js 2.75 kB
packages/navigation/dist/index.js 3.21 kB
packages/navigation/dist/style.css 874 B
packages/overlay/dist/index.es.js 1.02 kB
packages/overlay/dist/index.js 1.42 kB
packages/popover/dist/index.es.js 3.01 kB
packages/popover/dist/index.js 3.43 kB
packages/popover/dist/style.css 529 B
packages/portal/dist/index.es.js 420 B
packages/portal/dist/index.js 835 B
packages/table/dist/index.es.js 1.01 kB
packages/table/dist/index.js 1.44 kB
packages/table/dist/style.css 700 B
packages/tokens/dist/fonts.css 183 B
packages/tokens/dist/index.css 1.47 kB
packages/tokens/dist/index.es.js 3.07 kB
packages/tokens/dist/index.js 3.11 kB
packages/tokens/dist/media-queries.css 113 B
packages/tokens/dist/themes.css 2.27 kB
packages/tooltip/dist/index.es.js 598 B
packages/tooltip/dist/index.js 1.02 kB
packages/tooltip/dist/style.css 337 B
packages/vars/dist/index.es.js 2.66 kB
packages/vars/dist/index.js 2.66 kB

compressed-size-action

devin-ai-integration bot and others added 4 commits September 11, 2025 13:34
Add id-token: write and contents: read permissions to both generate-nodejs-sbom
and evaluate-policy jobs to enable access to private launchdarkly/common-actions repository.

Co-Authored-By: Patrick Kaeding <[email protected]>
Add CUSTOM_GITHUB_TOKEN retrieval via release-secrets action to both jobs
to enable access to private launchdarkly/common-actions repository.

Co-Authored-By: Patrick Kaeding <[email protected]>
Switch from private common-actions to public gh-actions for SEC-7263.
Simplify workflow structure to match working implementation.

Co-Authored-By: Patrick Kaeding <[email protected]>
Remove custom runs-on configuration that was causing runner resolution
failures. Simplify to standard ubuntu-latest for SEC-7263.

Co-Authored-By: Patrick Kaeding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant