Skip to content

Commit 40f9fb9

Browse files
6by9popcornmix
authored andcommitted
staging: bcm2835-camera: Replace deprecated V4L2_PIX_FMT_BGR32
V4L2_PIX_FMT_BGR32 is deprecated as it is ambiguous over where the alpha byte is. Cheese/GStreamer appear to get it wrong for one, and qv4l2 gets red and blue swapped. Swap to the newer V4L2_PIX_FMT_BGRX32 format. https://www.raspberrypi.org/forums/viewtopic.php?f=38&t=267736&p=1738912 Signed-off-by: Dave Stevenson <[email protected]>
1 parent 8e79c0b commit 40f9fb9

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ static struct mmal_fmt formats[] = {
177177
.ybbp = 1,
178178
.remove_padding = true,
179179
}, {
180-
.fourcc = V4L2_PIX_FMT_BGR32,
180+
.fourcc = V4L2_PIX_FMT_BGRX32,
181181
.mmal = MMAL_ENCODING_BGRA,
182182
.depth = 32,
183183
.mmal_component = COMP_CAMERA,

0 commit comments

Comments
 (0)