Skip to content

Change line lengths to 88 and enable ruff format --check #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcjones opened this issue Feb 29, 2024 · 1 comment
Closed

Change line lengths to 88 and enable ruff format --check #77

jcjones opened this issue Feb 29, 2024 · 1 comment

Comments

@jcjones
Copy link
Collaborator

jcjones commented Feb 29, 2024

There are some comments that have to change to move to 88 character line-length:

partitionmanager/cli.py:410:89: E501 Line too long (96 > 88)
partitionmanager/cli_test.py:228:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:231:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:534:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:539:89: E501 Line too long (94 > 88)
partitionmanager/cli_test.py:586:89: E501 Line too long (91 > 88)
partitionmanager/dropper.py:95:89: E501 Line too long (90 > 88)
partitionmanager/dropper_test.py:233:89: E501 Line too long (98 > 88)
partitionmanager/migrate.py:174:89: E501 Line too long (96 > 88)
partitionmanager/migrate.py:278:89: E501 Line too long (94 > 88)
partitionmanager/migrate_test.py:134:89: E501 Line too long (92 > 88)
partitionmanager/migrate_test.py:138:89: E501 Line too long (92 > 88)
partitionmanager/migrate_test.py:143:89: E501 Line too long (92 > 88)
partitionmanager/table_append_partition.py:88:89: E501 Line too long (91 > 88)
partitionmanager/table_append_partition.py:131:89: E501 Line too long (97 > 88)
partitionmanager/table_append_partition.py:244:89: E501 Line too long (91 > 88)
partitionmanager/table_append_partition.py:600:89: E501 Line too long (89 > 88)
partitionmanager/table_append_partition.py:700:89: E501 Line too long (94 > 88)
partitionmanager/types.py:344:89: E501 Line too long (98 > 88)

When we do this, we also should change the CI job to use ruff format --check to enforce the new formatting.

Originally posted by @jcjones in #75 (comment)

@cclauss
Copy link
Contributor

cclauss commented Mar 1, 2024

Closed in:

@jcjones jcjones closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants