Skip to content

SDL_ELF_NOTE_DLOPEN cannot be used with a toolchain not supporting variadic macros #14214

@madebr

Description

@madebr

SDL_ELF_NOTE_DLOPEN of SDL_dlopennote.h is currently designed to be used unconditionally.

#if !defined(SDL_PLATFORM_UNIX) || defined(SDL_PLATFORM_ANDROID)
/* The dlopen note functionality isn't used on this platform */
#ifndef SDL_DISABLE_DLOPEN_NOTES
#define SDL_DISABLE_DLOPEN_NOTES
#endif
#endif /* SDL_PLATFORM_UNIX || SDL_PLATFORM_ANDROID */
#if defined(__ELF__) && !defined(SDL_DISABLE_DLOPEN_NOTES)

However, it cannot be used with an (older) toolchain not supporting variadic macros.

Compiling testdlopennote.c of this PR fails with the error below (when using MSVC 6):

testdlopennote.c(13) : error C2059: syntax error : 'string'

Defining SDL_DISABLE_DLOPEN_NOTES does not help since it is already defined (Windows is not a unix platform).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions