f probe success if payment_failed_permanently

Author: valentinewallace

lightning-background-processor/src/lib.rs

@@ -226,14 +226,13 @@ fn update_scorer<'a, S: 'static + Deref<Target = SC> + Send + Sync, SC: 'a + Wri
 ) {
 	let mut score = scorer.lock();
 	match event {
-		Event::PaymentPathFailed { ref path, short_channel_id, .. } => {
+		Event::PaymentPathFailed { ref path, short_channel_id, payment_failed_permanently, .. } => {
 			let path = path.iter().collect::<Vec<_>>();
 			if let Some(scid) = short_channel_id {
 				score.payment_path_failed(&path, *scid);
-			} else {
-				// `short_channel_id` will be None when the destination explicitly failed it back. We treat
-				// this as a successful probe because the payment made it all the way to the destination
-				// with sufficient liquidity.
+			} else if *payment_failed_permanently {
+				// Reached if the destination explicitly failed it back. We treat this as a successful probe
+				// because the payment made it all the way to the destination with sufficient liquidity.
 				score.probe_successful(&path);
 			}
 		},