Add extra state-implies-inbound debug assertion in channel

TheBlueMatt · TheBlueMatt · commit ce4e20d6f5e4 · 2021-08-16T23:48:05.000Z
diff --git a/lightning/src/ln/channel.rs b/lightning/src/ln/channel.rs
@@ -2477,6 +2477,7 @@ impl<Signer: Sign> Channel<Signer> {
 		let mut need_commitment = false;
 		if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {
 			if *update_state == FeeUpdateState::RemoteAnnounced {
+				debug_assert!(!self.is_outbound());
 				*update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;
 				need_commitment = true;
 			}

Original file line number	Diff line number	Diff line change
`@@ -2477,6 +2477,7 @@ impl<Signer: Sign> Channel<Signer> {`
`2477`	`2477`	`let mut need_commitment = false;`
`2478`	`2478`	`if let &mut Some((_, ref mut update_state)) = &mut self.pending_update_fee {`
`2479`	`2479`	`if *update_state == FeeUpdateState::RemoteAnnounced {`
	`2480`	`+ debug_assert!(!self.is_outbound());`
`2480`	`2481`	`*update_state = FeeUpdateState::AwaitingRemoteRevokeToAnnounce;`
`2481`	`2482`	`need_commitment = true;`
`2482`	`2483`	`}`