Skip to content

Commit f83fa1a

Browse files
committed
Increase the log level of several channelmonitor logs.
Channelmonitor log entries can generally lean towards being higher log levels than they necessarily need to be, as they should be exceedingly rare, if only because they require confirmation of an on-chain transaction.
1 parent d80c534 commit f83fa1a

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

lightning/src/chain/channelmonitor.rs

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1543,7 +1543,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
15431543
// Last, track onchain revoked commitment transaction and fail backward outgoing HTLCs as payment path is broken
15441544
if !claimable_outpoints.is_empty() || per_commitment_option.is_some() { // ie we're confident this is actually ours
15451545
// We're definitely a counterparty commitment transaction!
1546-
log_trace!(logger, "Got broadcast of revoked counterparty commitment transaction, going to generate general spend tx with {} inputs", claimable_outpoints.len());
1546+
log_error!(logger, "Got broadcast of revoked counterparty commitment transaction, going to generate general spend tx with {} inputs", claimable_outpoints.len());
15471547
for (idx, outp) in tx.output.iter().enumerate() {
15481548
watch_outputs.push((idx as u32, outp.clone()));
15491549
}
@@ -1599,7 +1599,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
15991599
}
16001600
self.counterparty_commitment_txn_on_chain.insert(commitment_txid, commitment_number);
16011601

1602-
log_trace!(logger, "Got broadcast of non-revoked counterparty commitment transaction {}", commitment_txid);
1602+
log_info!(logger, "Got broadcast of non-revoked counterparty commitment transaction {}", commitment_txid);
16031603

16041604
macro_rules! check_htlc_fails {
16051605
($txid: expr, $commitment_tx: expr, $id: tt) => {
@@ -1717,7 +1717,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
17171717
let per_commitment_key = ignore_error!(SecretKey::from_slice(&secret));
17181718
let per_commitment_point = PublicKey::from_secret_key(&self.secp_ctx, &per_commitment_key);
17191719

1720-
log_trace!(logger, "Counterparty HTLC broadcast {}:{}", htlc_txid, 0);
1720+
log_error!(logger, "Got broadcast of revoked counterparty HTLC transaction, spending {}:{}", htlc_txid, 0);
17211721
let revk_outp = RevokedOutput::build(per_commitment_point, self.counterparty_tx_cache.counterparty_delayed_payment_base_key, self.counterparty_tx_cache.counterparty_htlc_base_key, per_commitment_key, tx.output[0].value, self.counterparty_tx_cache.on_counterparty_tx_csv);
17221722
let justice_package = PackageTemplate::build_package(htlc_txid, 0, PackageSolvingData::RevokedOutput(revk_outp), height + self.counterparty_tx_cache.on_counterparty_tx_csv as u32, true, height);
17231723
let claimable_outpoints = vec!(justice_package);
@@ -1808,14 +1808,14 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
18081808

18091809
if self.current_holder_commitment_tx.txid == commitment_txid {
18101810
is_holder_tx = true;
1811-
log_trace!(logger, "Got latest holder commitment tx broadcast, searching for available HTLCs to claim");
1811+
log_info!(logger, "Got broadcast of latest holder commitment tx {}, searching for available HTLCs to claim", commitment_txid);
18121812
let res = self.get_broadcasted_holder_claims(&self.current_holder_commitment_tx, height);
18131813
let mut to_watch = self.get_broadcasted_holder_watch_outputs(&self.current_holder_commitment_tx, tx);
18141814
append_onchain_update!(res, to_watch);
18151815
} else if let &Some(ref holder_tx) = &self.prev_holder_signed_commitment_tx {
18161816
if holder_tx.txid == commitment_txid {
18171817
is_holder_tx = true;
1818-
log_trace!(logger, "Got previous holder commitment tx broadcast, searching for available HTLCs to claim");
1818+
log_info!(logger, "Got broadcast of previous holder commitment tx {}, searching for available HTLCs to claim", commitment_txid);
18191819
let res = self.get_broadcasted_holder_claims(holder_tx, height);
18201820
let mut to_watch = self.get_broadcasted_holder_watch_outputs(holder_tx, tx);
18211821
append_onchain_update!(res, to_watch);
@@ -1845,7 +1845,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
18451845
}
18461846

18471847
pub fn get_latest_holder_commitment_txn<L: Deref>(&mut self, logger: &L) -> Vec<Transaction> where L::Target: Logger {
1848-
log_trace!(logger, "Getting signed latest holder commitment transaction!");
1848+
log_debug!(logger, "Getting signed latest holder commitment transaction!");
18491849
self.holder_tx_signed = true;
18501850
let commitment_tx = self.onchain_tx_handler.get_fully_signed_holder_tx(&self.funding_redeemscript);
18511851
let txid = commitment_tx.txid();
@@ -1879,7 +1879,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
18791879
#[cfg(any(test,feature = "unsafe_revoked_tx_signing"))]
18801880
/// Note that this includes possibly-locktimed-in-the-future transactions!
18811881
fn unsafe_get_latest_holder_commitment_txn<L: Deref>(&mut self, logger: &L) -> Vec<Transaction> where L::Target: Logger {
1882-
log_trace!(logger, "Getting signed copy of latest holder commitment transaction!");
1882+
log_debug!(logger, "Getting signed copy of latest holder commitment transaction!");
18831883
let commitment_tx = self.onchain_tx_handler.get_fully_signed_copy_holder_tx(&self.funding_redeemscript);
18841884
let txid = commitment_tx.txid();
18851885
let mut holder_transactions = vec![commitment_tx];
@@ -2086,15 +2086,15 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
20862086
matured_htlcs.push(source.clone());
20872087
}
20882088

2089-
log_trace!(logger, "HTLC {} failure update has got enough confirmations to be passed upstream", log_bytes!(payment_hash.0));
2089+
log_debug!(logger, "HTLC {} failure update has got enough confirmations to be passed upstream", log_bytes!(payment_hash.0));
20902090
self.pending_monitor_events.push(MonitorEvent::HTLCEvent(HTLCUpdate {
20912091
payment_hash: payment_hash,
20922092
payment_preimage: None,
20932093
source: source.clone(),
20942094
}));
20952095
},
20962096
OnchainEvent::MaturingOutput { descriptor } => {
2097-
log_trace!(logger, "Descriptor {} has got enough confirmations to be passed upstream", log_spendable!(descriptor));
2097+
log_debug!(logger, "Descriptor {} has got enough confirmations to be passed upstream", log_spendable!(descriptor));
20982098
self.pending_events.push(Event::SpendableOutputs {
20992099
outputs: vec![descriptor]
21002100
});
@@ -2463,7 +2463,7 @@ impl<Signer: Sign> ChannelMonitorImpl<Signer> {
24632463
height: height,
24642464
event: OnchainEvent::MaturingOutput { descriptor: spendable_output.clone() },
24652465
};
2466-
log_trace!(logger, "Maturing {} until {}", log_spendable!(spendable_output), entry.confirmation_threshold());
2466+
log_info!(logger, "Received spendable output {}, spendable at height {}", log_spendable!(spendable_output), entry.confirmation_threshold());
24672467
self.onchain_events_awaiting_threshold_conf.push(entry);
24682468
}
24692469
}

0 commit comments

Comments
 (0)