Skip to content

Holder HTLC transactions' fee-bumping timers should be scheduled on their CLTV timelocks #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ariard opened this issue Jun 30, 2021 · 1 comment
Assignees

Comments

@ariard
Copy link

ariard commented Jun 30, 2021

Currently in get_broadcasted_holder_claims we pass confirmation height of the commitment transaction (at least after #970) which have the disadvantage of artificially increase the fee-bumping frequency of such transaction at the CLTV absolute height might be still far ahead in the future. Instead we should pass htlc.cltv_expiry to PackageTemplate::build_output.

Need a test.

@ariard ariard self-assigned this Jun 30, 2021
@TheBlueMatt
Copy link
Collaborator

I went ahead and updated #970 to pass the htlc.cltv_expiry value instead cause I agree its "more" correct, but we do need a test around this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants