sweepbatcher: fix a bug in dest address selection

starius · starius · commit e03ba71f29ef · 2025-06-24T12:48:30.000-03:00
For presigned possible remaining groups, the destination address of the current
batch was used instead of the destination address of an expected future batch.

TODO: reproduce in unit test "purged". For this, each swap should have a
separate destination address.
diff --git a/sweepbatcher/presigned.go b/sweepbatcher/presigned.go
@@ -248,7 +248,7 @@ func (b *batch) presign(ctx context.Context, newSweeps []*sweep) error {
 
 		// Cache the destination address.
 		destAddr, err := getPresignedSweepsDestAddr(
-			ctx, b.cfg.presignedHelper, b.primarySweepID,
+			ctx, b.cfg.presignedHelper, primarySweepID,
 			b.cfg.chainParams,
 		)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ func (b batch) presign(ctx context.Context, newSweeps []sweep) error {`
`248`	`248`
`249`	`249`	`// Cache the destination address.`
`250`	`250`	`destAddr, err := getPresignedSweepsDestAddr(`
`251`		`- ctx, b.cfg.presignedHelper, b.primarySweepID,`
	`251`	`+ ctx, b.cfg.presignedHelper, primarySweepID,`
`252`	`252`	`b.cfg.chainParams,`
`253`	`253`	`)`
`254`	`254`	`if err != nil {`