Skip to content

Commit 904ecad

Browse files
wdebruijNipaLocal
authored and
NipaLocal
committed
fou: remove warn in gue_gro_receive on unsupported protocol
Drop the WARN_ON_ONCE inn gue_gro_receive if the encapsulated type is not known or does not have a GRO handler. Such a packet is easily constructed. Syzbot generates them and sets off this warning. Remove the warning as it is expected and not actionable. The warning was previously reduced from WARN_ON to WARN_ON_ONCE in commit 2701366 ("fou: Do WARN_ON_ONCE in gue_gro_receive for bad proto callbacks"). Signed-off-by: Willem de Bruijn <[email protected]> Reviewed-by: Eric Dumazet <[email protected]> Signed-off-by: NipaLocal <nipa@local>
1 parent 6c45b1a commit 904ecad

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

net/ipv4/fou_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ static struct sk_buff *gue_gro_receive(struct sock *sk,
433433

434434
offloads = NAPI_GRO_CB(skb)->is_ipv6 ? inet6_offloads : inet_offloads;
435435
ops = rcu_dereference(offloads[proto]);
436-
if (WARN_ON_ONCE(!ops || !ops->callbacks.gro_receive))
436+
if (!ops || !ops->callbacks.gro_receive)
437437
goto out;
438438

439439
pp = call_gro_receive(ops->callbacks.gro_receive, head, skb);

0 commit comments

Comments
 (0)