Skip to content

Commit fd45cc6

Browse files
knaerzchemmind
authored andcommitted
drm/rockchip: inno-hdmi: Fix infoframe upload
HDMI analyser shows that the AVI infoframe is no being longer send. The switch to the HDMI connector api should have used the frame content which is now given in the buffer parameter, but instead still uses the (now) empty and superfluous packed_frame variable. Fix it. Fixes: 65548c8 ("drm/rockchip: inno_hdmi: Switch to HDMI connector") Signed-off-by: Alex Bee <[email protected]> Acked-by: Maxime Ripard <[email protected]> Signed-off-by: Heiko Stuebner <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 497d370 commit fd45cc6

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/gpu/drm/rockchip/inno_hdmi.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,6 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
279279
const u8 *buffer, size_t len)
280280
{
281281
struct inno_hdmi *hdmi = connector_to_inno_hdmi(connector);
282-
u8 packed_frame[HDMI_MAXIMUM_INFO_FRAME_SIZE];
283282
ssize_t i;
284283

285284
if (type != HDMI_INFOFRAME_TYPE_AVI) {
@@ -291,8 +290,7 @@ static int inno_hdmi_upload_frame(struct drm_connector *connector,
291290
inno_hdmi_disable_frame(connector, type);
292291

293292
for (i = 0; i < len; i++)
294-
hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i,
295-
packed_frame[i]);
293+
hdmi_writeb(hdmi, HDMI_CONTROL_PACKET_ADDR + i, buffer[i]);
296294

297295
return 0;
298296
}

0 commit comments

Comments
 (0)