Gandi.net API key is deprecated in favor of Gandi.net Personal Access Token (PAT) #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for opening this pull request! Be sure to follow the pull request template!
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
|
I am a bot, here is the pushed image/manifest for this PR:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
(Re)enable the support of the Gandi API Personal Access Token (PAT) for the Gandi DNS plugin located at
root/defaults/dns-conf/gandi.iniwith the correct name of the variable used in Gandi Certbot plugin on which this project depends.Actually in
root/defaults/dns-conf/gandi.ini:but that has to be changed to:
Since linuxserver/docker-swag no longer work with the old
dns_gandi_api_keyvariable in gandi.ini file, as it refers to the Gandi API Key authentication method, which is obsolete.dns_gandi_tokenis the correct variable used with Gandi PAT in the Gandi Certbot Plugin.Benefits of this PR and context:
Before this change, the Gandi Certbot plugin accepted both the Gandi API key and the Gandi personal access token. Now, only the personal access token is supported by the Gandi Certbot plugin.
Linked issues : #426
How Has This Been Tested?
After having issues when I would like to setup a new instance of docker-swag with a Gandi domain + DNS challenge. I tried to understand how the Gandi Certbot plugin works and I found in this in the documentation of Gandi Certbot Plugin repo :
I replaced the variable name by
dns_gandi_api_key=*******in and I no longer have any problems. The certificate has been issued.Source / References: