We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 07bd300 commit 27712eaCopy full SHA for 27712ea
mlir/lib/Bindings/Python/IRModule.h
@@ -1110,6 +1110,9 @@ class PyConcreteAttribute : public BaseTy {
1110
/// bindings so such operation always exists).
1111
class PyValue {
1112
public:
1113
+ // The virtual here is "load bearing" in that it enables RTTI
1114
+ // for PyConcreteValue CRTP classes that support maybeDownCast.
1115
+ // See PyValue::maybeDownCast.
1116
virtual ~PyValue() = default;
1117
PyValue(PyOperationRef parentOperation, MlirValue value)
1118
: parentOperation(std::move(parentOperation)), value(value) {}
0 commit comments