Skip to content

Commit 2db7820

Browse files
[lldb] [llgs] Fix assertion in Handle_qfThreadInfo (#88301)
Currently, GDBRemoteCommunicationServerLLGS::Handle_qfThreadInfo asserts if the number of processes under debug isn’t 1 and the multiprocess feature isn’t supported. This is so that we don't string IDs of threads belonging to different processes together without including the IDs of the processes themselves in the response when there are multiple processes under debug. However, it’s conceivable that we have no process under debug and the multiprocess feature isn’t supported. So, have GDBRemoteCommunicationServerLLGS::Handle_qfThreadInfo assert if the number of processes under debug is greater than 1 and the multiprocess feature isn’t supported.
1 parent 1837681 commit 2db7820

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2087,7 +2087,7 @@ void GDBRemoteCommunicationServerLLGS::AddProcessThreads(
20872087
GDBRemoteCommunication::PacketResult
20882088
GDBRemoteCommunicationServerLLGS::Handle_qfThreadInfo(
20892089
StringExtractorGDBRemote &packet) {
2090-
assert(m_debugged_processes.size() == 1 ||
2090+
assert(m_debugged_processes.size() <= 1 ||
20912091
bool(m_extensions_supported &
20922092
NativeProcessProtocol::Extension::multiprocess));
20932093

0 commit comments

Comments
 (0)