Skip to content

Commit 52220c2

Browse files
authored
[AMDGPU][AsmParser][NFC] Remove a misleading comment. (#102604)
The work of ParseRegularReg() should remain to be parsing the register as it was specified, and not to try translate it to anything else. It's up to operand predicates to decide on what is and is not an acceptable register for an operand, including considering its expected register class, and for the rest of the AsmParser infrastructure to handle it respectively from there on.
1 parent 9e9fa00 commit 52220c2

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2937,10 +2937,6 @@ unsigned AMDGPUAsmParser::ParseRegularReg(RegisterKind &RegKind,
29372937
StringRef RegSuffix = RegName.substr(RI->Name.size());
29382938
unsigned SubReg = NoSubRegister;
29392939
if (!RegSuffix.empty()) {
2940-
// We don't know the opcode till we are done parsing, so we don't know if
2941-
// registers should be 16 or 32 bit. It is therefore mandatory to put .l or
2942-
// .h to correctly specify 16 bit registers. We also can't determine class
2943-
// VGPR_16_Lo128 or VGPR_16, so always parse them as VGPR_16.
29442940
if (RegSuffix.consume_back(".l"))
29452941
SubReg = AMDGPU::lo16;
29462942
else if (RegSuffix.consume_back(".h"))

0 commit comments

Comments
 (0)