Skip to content

Commit 616d30c

Browse files
committed
[AMDGPU][AsmParser][NFC] Simplify the EndpgmImm operand definition.
Clears the road to eliminating custom default operand handlers. Also unifies naming of related entities. Part of <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D151687
1 parent 2f2af2d commit 616d30c

File tree

3 files changed

+6
-17
lines changed

3 files changed

+6
-17
lines changed

llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1823,8 +1823,8 @@ class AMDGPUAsmParser : public MCTargetAsmParser {
18231823
AMDGPUOperand::Ptr defaultCBSZ() const;
18241824
AMDGPUOperand::Ptr defaultABID() const;
18251825

1826-
OperandMatchResultTy parseEndpgmOp(OperandVector &Operands);
1827-
AMDGPUOperand::Ptr defaultEndpgmImmOperands() const;
1826+
OperandMatchResultTy parseEndpgm(OperandVector &Operands);
1827+
AMDGPUOperand::Ptr defaultEndpgm() const;
18281828

18291829
AMDGPUOperand::Ptr defaultWaitVDST() const;
18301830
AMDGPUOperand::Ptr defaultWaitEXP() const;
@@ -8713,7 +8713,7 @@ AMDGPUOperand::Ptr AMDGPUAsmParser::defaultDppRowMask() const {
87138713
return AMDGPUOperand::CreateImm(this, 0xf, SMLoc(), AMDGPUOperand::ImmTyDppRowMask);
87148714
}
87158715

8716-
AMDGPUOperand::Ptr AMDGPUAsmParser::defaultEndpgmImmOperands() const {
8716+
AMDGPUOperand::Ptr AMDGPUAsmParser::defaultEndpgm() const {
87178717
return AMDGPUOperand::CreateImm(this, 0, SMLoc(), AMDGPUOperand::ImmTyEndpgm);
87188718
}
87198719

@@ -9196,7 +9196,7 @@ unsigned AMDGPUAsmParser::validateTargetOperandClass(MCParsedAsmOperand &Op,
91969196
// endpgm
91979197
//===----------------------------------------------------------------------===//
91989198

9199-
OperandMatchResultTy AMDGPUAsmParser::parseEndpgmOp(OperandVector &Operands) {
9199+
OperandMatchResultTy AMDGPUAsmParser::parseEndpgm(OperandVector &Operands) {
92009200
SMLoc S = getLoc();
92019201
int64_t Imm = 0;
92029202

llvm/lib/Target/AMDGPU/SIInstrInfo.td

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -980,14 +980,6 @@ def SwizzleMatchClass : AsmOperandClass {
980980
let IsOptional = 1;
981981
}
982982

983-
def EndpgmMatchClass : AsmOperandClass {
984-
let Name = "EndpgmImm";
985-
let PredicateMethod = "isEndpgm";
986-
let ParserMethod = "parseEndpgmOp";
987-
let RenderMethod = "addImmOperands";
988-
let IsOptional = 1;
989-
}
990-
991983
def SWaitMatchClass : AsmOperandClass {
992984
let Name = "SWaitCnt";
993985
let RenderMethod = "addImmOperands";
@@ -1022,10 +1014,7 @@ def SwizzleImm : Operand<i16> {
10221014
let ParserMatchClass = SwizzleMatchClass;
10231015
}
10241016

1025-
def EndpgmImm : Operand<i16> {
1026-
let PrintMethod = "printEndpgm";
1027-
let ParserMatchClass = EndpgmMatchClass;
1028-
}
1017+
def Endpgm : CustomOperand<i16, 1>;
10291018

10301019
def WAIT_FLAG : Operand <i32> {
10311020
let ParserMatchClass = SWaitMatchClass;

llvm/lib/Target/AMDGPU/SOPInstructions.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1175,7 +1175,7 @@ multiclass SOPP_With_Relaxation <string opName, dag ins,
11751175
def S_NOP : SOPP_Pseudo<"s_nop" , (ins i16imm:$simm16), "$simm16">;
11761176

11771177
let isTerminator = 1 in {
1178-
def S_ENDPGM : SOPP_Pseudo<"s_endpgm", (ins EndpgmImm:$simm16), "$simm16", [], ""> {
1178+
def S_ENDPGM : SOPP_Pseudo<"s_endpgm", (ins Endpgm:$simm16), "$simm16", [], ""> {
11791179
let isBarrier = 1;
11801180
let isReturn = 1;
11811181
let hasSideEffects = 1;

0 commit comments

Comments
 (0)