Skip to content

Commit 6b54ecc

Browse files
committed
[mlgo] remove inlining_default - unused feature
The feature was only exposed for training and was immediately dropped on the training side. It was bulk-copied into the test model generator, where it had no effect (the generator always returns a constant). In the AOT + test model case, since the test model returns a constant, all input features are pruned by the AOT compiler, so its presence/absence doesn't matter.
1 parent 1adf0fa commit 6b54ecc

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ class LoggingMLInlineAdvice : public MLInlineAdvice {
253253
};
254254

255255
static const std::vector<TensorSpec> TrainingOnlyFeatures{
256-
TensorSpec::createSpec<int64_t>(TFFeedPrefix + "inlining_default", {1}),
257256
TensorSpec::createSpec<float>(TFFeedPrefix + "discount", {1}),
258257
TensorSpec::createSpec<float>(TFFeedPrefix + "reward", {1}),
259258
TensorSpec::createSpec<int32_t>(TFFeedPrefix + "step_type", {1})};

llvm/lib/Analysis/models/gen-inline-oz-test-model.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ def get_input_signature():
4747
"edge_count",
4848
"callsite_height",
4949
"cost_estimate",
50-
"inlining_default",
5150
"sroa_savings",
5251
"sroa_losses",
5352
"load_elimination",

0 commit comments

Comments
 (0)