More review fixups

Author: MacDue

mlir/lib/Dialect/ArmSME/Transforms/TileAllocation.cpp

@@ -414,7 +414,7 @@ coalesceTileLiveRanges(DenseMap<Value, LiveRange> &initialLiveRanges) {
   return std::move(coalescedLiveRanges);
 }
 
-/// Greedily allocate tile IDs to live ranges spill using simple heuristics.
+/// Greedily allocate tile IDs to live ranges. Spill using simple heuristics.
 /// Note: This does not attempt to fill holes in live/allocated ranges.
 void allocateTilesToLiveRanges(ArrayRef<LiveRange *> liveRanges) {
   TileAllocator tileAllocator;
@@ -629,8 +629,8 @@ LogicalResult mlir::arm_sme::allocateSMETiles(FunctionOpInterface function,
     return failure();
   }
 
-  /// 6. Erase trivially dead tile operations (e.g. a ZeroOp with no
-  /// users). This prevents the LLVM conversion needlessly inserting spills.
+  // 6. Erase trivially dead tile operations (e.g. a ZeroOp with no
+  // users). This prevents the LLVM conversion needlessly inserting spills.
   eraseTriviallyDeadTileOps(rewriter, function);
   return success();
 }

mlir/test/Conversion/ArmSMEToLLVM/unsupported.mlir

@@ -1,5 +1,4 @@
-// RUN: mlir-opt %s --pass-pipeline="builtin.module(func.func(convert-arm-sme-to-llvm))" \
-// RUN: -split-input-file -allow-unregistered-dialect -verify-diagnostics
+// RUN: mlir-opt %s --pass-pipeline="builtin.module(func.func(convert-arm-sme-to-llvm))" -verify-diagnostics
 
 //===----------------------------------------------------------------------===//
 // arm_sme.outerproduct
@@ -10,6 +9,6 @@ func.func @arm_sme_outerproduct_unsupported_type(%lhs : vector<[16]xi8>, %rhs :
   // expected-error@+2 {{failed to legalize operation 'arm_sme.outerproduct'}}
   // expected-error@+1 {{unsupported type}}
   %0 = arm_sme.outerproduct %lhs, %rhs  acc(%acc) : vector<[16]xi8>, vector<[16]xi8>
-  "prevent.dce"(%0) : (vector<[16]x[16]xi8>) -> ()
+  "test.some_use"(%0) : (vector<[16]x[16]xi8>) -> ()
 }
 

mlir/test/Dialect/ArmSME/basic-tile-allocation.mlir

@@ -56,16 +56,6 @@ func.func @za_b_overlapping_za_q() {
 
 // -----
 
-// CHECK-LABEL: za0_h
-func.func @za0_h() {
-  // CHECK-NEXT: tile_id = 0
-  %za0_h = arm_sme.get_tile : vector<[8]x[8]xi16>
-  "test.some_use"(%za0_h) : (vector<[8]x[8]xi16>) -> ()
-  return
-}
-
-// -----
-
 // CHECK-LABEL: za_h
 func.func @za_h() {
   // CHECK-NEXT: tile_id = 0
@@ -167,16 +157,6 @@ func.func @za_h_overlapping_za_q() {
 
 // -----
 
-// CHECK-LABEL: za0_s
-func.func @za0_s() {
-  // CHECK-NEXT: tile_id = 0
-  %za0_s = arm_sme.get_tile : vector<[4]x[4]xi32>
-  "test.some_use"(%za0_s) : (vector<[4]x[4]xi32>) -> ()
-  return
-}
-
-// -----
-
 // CHECK-LABEL: za_s
 func.func @za_s() {
   // CHECK-NEXT: tile_id = 0
@@ -277,16 +257,6 @@ func.func @za_s_overlapping_za_q() {
 
 // -----
 
-// CHECK-LABEL: za0_d
-func.func @za0_d() {
-  // CHECK-NEXT: tile_id = 0
-  %za0_d = arm_sme.get_tile : vector<[2]x[2]xi64>
-  "test.some_use"(%za0_d) : (vector<[2]x[2]xi64>) -> ()
-  return
-}
-
-// -----
-
 // CHECK-LABEL: za_d
 func.func @za_d() {
   // CHECK-NEXT: tile_id = 0
@@ -378,16 +348,6 @@ func.func @za_d_overlapping_za_q() {
 
 // -----
 
-// CHECK-LABEL: za0_q
-func.func @za0_q() {
-  // CHECK-NEXT: tile_id = 0
-  %za0_q = arm_sme.get_tile : vector<[1]x[1]xi128>
-  "test.some_use"(%za0_q) : (vector<[1]x[1]xi128>) -> ()
-  return
-}
-
-// -----
-
 // CHECK-LABEL: za_q
 func.func @za_q() {
   // CHECK-NEXT: tile_id = 0

mlir/test/Dialect/ArmSME/canonicalize.mlir

@@ -1,9 +1,7 @@
-// RUN: mlir-opt -canonicalize -split-input-file -verify-diagnostics %s | mlir-opt | FileCheck %s
+// RUN: mlir-opt %s -canonicalize | mlir-opt | FileCheck %s
 
 // This tests that dead tile values are removed from control flow.
 
-// -----
-
 // CHECK-LABEL: @unused_ssa_tile_is_removed_from_blocks
 // CHECK-NOT: vector<[4]x[4]xf32>
 func.func @unused_ssa_tile_is_removed_from_blocks(%arg0: memref<?x?xi32>) {