Skip to content

Commit 7f215b1

Browse files
authored
[runtimes] Add missing test dependencies to check-all (#72955)
The test-depends target contained all the dependencies needed to run the runtimes tests, but it was never added as a dependency of check-all. This caused some of the tsan tests to fail, since the custom libcxx build the tests were looking for was never built. Besides the tsan failures, this fixes all the other test failures I was seeing with: cmake -G Ninja -B release-build -S llvm \ -DCMAKE_POSITION_INDEPENDENT_CODE=ON \ -DCMAKE_BUILD_TYPE=Release \ -DLLVM_ENABLE_ASSERTIONS=OFF \ -DLLVM_ENABLE_PROJECTS="clang;lld" \ -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt" This is the same configuration the test-release.sh script uses, so I'm hoping this will also fix all the test failures we've been seeing when building the releases. Fixes #58680
1 parent 58286f9 commit 7f215b1

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

llvm/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1255,6 +1255,7 @@ if( LLVM_INCLUDE_TESTS )
12551255
add_custom_target(test-depends
12561256
DEPENDS ${LLVM_ALL_LIT_DEPENDS} ${LLVM_ALL_ADDITIONAL_TEST_DEPENDS})
12571257
set_target_properties(test-depends PROPERTIES FOLDER "Tests")
1258+
add_dependencies(check-all test-depends)
12581259
endif()
12591260

12601261
if (LLVM_INCLUDE_DOCS)

0 commit comments

Comments
 (0)