Skip to content

Commit 84c89d0

Browse files
authored
[LV][EVL] Address post-commit comments for 9720be9. (NFC) (#123311)
1 parent 295d1c3 commit 84c89d0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -1438,11 +1438,11 @@ class LoopVectorizationCostModel {
14381438
// Override forced styles if needed.
14391439
// FIXME: use actual opcode/data type for analysis here.
14401440
// FIXME: Investigate opportunity for fixed vector factor.
1441+
// FIXME: support fixed-order recurrences by fixing splice of non VFxUF
1442+
// penultimate EVL.
14411443
bool EVLIsLegal =
14421444
UserIC <= 1 && TTI.hasActiveVectorLength(0, nullptr, Align()) &&
1443-
!EnableVPlanNativePath &&
1444-
// FIXME: remove this once fixed-ordered recurrence is supported.
1445-
Legal->getFixedOrderRecurrences().empty();
1445+
!EnableVPlanNativePath && Legal->getFixedOrderRecurrences().empty();
14461446
if (!EVLIsLegal) {
14471447
// If for some reason EVL mode is unsupported, fallback to
14481448
// DataWithoutLaneMask to try to vectorize the loop with folded tail

llvm/test/Transforms/LoopVectorize/RISCV/vectorize-force-tail-with-evl-fixed-order-recurrence.ll

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
; RUN: -mtriple=riscv64 -mattr=+v,+f -S < %s| FileCheck %s --check-prefix=NO-VP
1313

1414
; FIXME: Fixed-order recurrence is not supported yet with EVL tail folding.
15-
; The llvm.splice may occurs unexpected behavior if the evl of the
16-
; second-to-last iteration is not VF*UF.
15+
; The llvm.splice may occur unexpected behavior if the evl of the second-to-last
16+
; iteration is not VF*UF.
1717

1818
define void @first_order_recurrence(ptr noalias %A, ptr noalias %B, i64 %TC) {
1919
; IF-EVL-LABEL: define void @first_order_recurrence(

0 commit comments

Comments
 (0)