Skip to content

Commit 947e12d

Browse files
committedOct 25, 2024
Allow Specifying the builder image.
This change attempts to shift the libc++ builders over to new backend infrastructure that allows running an arbitrary container for the libc++ job. This has been a long time in the making, and support from github and gke is finally at the point where it's possible (hopefully). This change should also demonstrate another important property: No Downtime Upgrades. If this goes well, we'll be able to test the upgrade as a part of the PR process, and then commiting it to main should (ideally) not break anything.
1 parent 1bc2cd9 commit 947e12d

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed
 

‎.github/workflows/libcxx-build-and-test.yaml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ env:
4949
jobs:
5050
stage1:
5151
if: github.repository_owner == 'llvm'
52-
runs-on: libcxx-runners-8-set
52+
runs-on: libcxx-runners-set
53+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
5354
continue-on-error: false
5455
strategy:
5556
fail-fast: false
@@ -84,7 +85,8 @@ jobs:
8485
**/crash_diagnostics/*
8586
stage2:
8687
if: github.repository_owner == 'llvm'
87-
runs-on: libcxx-runners-8-set
88+
runs-on: libcxx-runners-set
89+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
8890
needs: [ stage1 ]
8991
continue-on-error: false
9092
strategy:
@@ -160,20 +162,21 @@ jobs:
160162
'benchmarks',
161163
'bootstrapping-build'
162164
]
163-
machine: [ 'libcxx-runners-8-set' ]
165+
machine: [ 'libcxx-runners-set' ]
164166
include:
165167
- config: 'generic-cxx26'
166-
machine: libcxx-runners-8-set
168+
machine: libcxx-runners-set
167169
- config: 'generic-asan'
168-
machine: libcxx-runners-8-set
170+
machine: libcxx-runners-set
169171
- config: 'generic-tsan'
170-
machine: libcxx-runners-8-set
172+
machine: libcxx-runners-set
171173
- config: 'generic-ubsan'
172-
machine: libcxx-runners-8-set
174+
machine: libcxx-runners-set
173175
# Use a larger machine for MSAN to avoid timeout and memory allocation issues.
174176
- config: 'generic-msan'
175-
machine: libcxx-runners-8-set
177+
machine: libcxx-runners-set
176178
runs-on: ${{ matrix.machine }}
179+
container: ghcr.io/libcxx/actions-builder:testing-2024-09-21
177180
steps:
178181
- uses: actions/checkout@v4
179182
- name: ${{ matrix.config }}

0 commit comments

Comments
 (0)