Skip to content

Commit a9636b7

Browse files
authored
[mlir][StorageUniquer] Restore old signature for default implementaion of verifyInvariants. (#103023)
PR #102326 changed the prototype of the default implementation of verify to include emitErrorFn. This breaks automatic derivation in consumer attributes, such as https://github.com/tensorflow/runtime/blob/60277ba976739502e45ad26585e071568fa44af1/include/tfrt/core_runtime/opdefs/attributes.h#L53. This PR simply restores the signature to what it was prior to PR #102326.
1 parent 5ce47a5 commit a9636b7

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

mlir/include/mlir/IR/StorageUniquerSupport.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,7 @@ class StorageUserBase : public BaseT, public Traits<ConcreteT>... {
226226

227227
/// Default implementation that just returns success.
228228
template <typename... Args>
229-
static LogicalResult
230-
verifyInvariants(function_ref<InFlightDiagnostic()> emitErrorFn,
231-
Args... args) {
229+
static LogicalResult verifyInvariants(Args... args) {
232230
return success();
233231
}
234232

0 commit comments

Comments
 (0)