Skip to content

Commit afc24ed

Browse files
scott-linderscott-linder
committed
[AMDGPU] Mark test functions with hidden visibility
Prepare for future patch which affects codegen for calls to preemptible functions. Differential Revision: https://reviews.llvm.org/D57605 llvm-svn: 352920
1 parent de9ffab commit afc24ed

File tree

8 files changed

+70
-70
lines changed

8 files changed

+70
-70
lines changed

‎llvm/test/CodeGen/AMDGPU/byval-frame-setup.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
; GCN-NOT: s32
1515
; GCN: buffer_store_dword [[LOAD1]], off, s[0:3], s5 offset:20{{$}}
1616
; GCN-NOT: s32
17-
define void @void_func_byval_struct(%struct.ByValStruct addrspace(5)* byval noalias nocapture align 4 %arg0, %struct.ByValStruct addrspace(5)* byval noalias nocapture align 4 %arg1) #1 {
17+
define hidden void @void_func_byval_struct(%struct.ByValStruct addrspace(5)* byval noalias nocapture align 4 %arg0, %struct.ByValStruct addrspace(5)* byval noalias nocapture align 4 %arg1) #1 {
1818
entry:
1919
%arrayidx = getelementptr inbounds %struct.ByValStruct, %struct.ByValStruct addrspace(5)* %arg0, i32 0, i32 0, i32 0
2020
%tmp = load volatile i32, i32 addrspace(5)* %arrayidx, align 4
@@ -193,7 +193,7 @@ entry:
193193
; GCN-NOT: s32
194194
; GCN: buffer_store_dword [[LOAD1]], off, s[0:3], s5 offset:24{{$}}
195195
; GCN-NOT: s32
196-
define void @void_func_byval_struct_align8(%struct.ByValStruct addrspace(5)* byval noalias nocapture align 8 %arg0, %struct.ByValStruct addrspace(5)* byval noalias nocapture align 8 %arg1) #1 {
196+
define hidden void @void_func_byval_struct_align8(%struct.ByValStruct addrspace(5)* byval noalias nocapture align 8 %arg0, %struct.ByValStruct addrspace(5)* byval noalias nocapture align 8 %arg1) #1 {
197197
entry:
198198
%arrayidx = getelementptr inbounds %struct.ByValStruct, %struct.ByValStruct addrspace(5)* %arg0, i32 0, i32 0, i32 0
199199
%tmp = load volatile i32, i32 addrspace(5)* %arrayidx, align 8

‎llvm/test/CodeGen/AMDGPU/call-argument-types.ll

Lines changed: 47 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -3,56 +3,56 @@
33
; RUN: llc -march=amdgcn -mcpu=gfx900 -mattr=-flat-for-global -amdgpu-scalarize-global-loads=0 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,GFX9,VI,MESA %s
44
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=fiji -mattr=-flat-for-global -amdgpu-scalarize-global-loads=0 -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefixes=GCN,VI,HSA %s
55

6-
declare void @external_void_func_i1(i1) #0
7-
declare void @external_void_func_i1_signext(i1 signext) #0
8-
declare void @external_void_func_i1_zeroext(i1 zeroext) #0
9-
10-
declare void @external_void_func_i8(i8) #0
11-
declare void @external_void_func_i8_signext(i8 signext) #0
12-
declare void @external_void_func_i8_zeroext(i8 zeroext) #0
13-
14-
declare void @external_void_func_i16(i16) #0
15-
declare void @external_void_func_i16_signext(i16 signext) #0
16-
declare void @external_void_func_i16_zeroext(i16 zeroext) #0
17-
18-
declare void @external_void_func_i32(i32) #0
19-
declare void @external_void_func_i64(i64) #0
20-
declare void @external_void_func_v2i64(<2 x i64>) #0
21-
declare void @external_void_func_v3i64(<3 x i64>) #0
22-
declare void @external_void_func_v4i64(<4 x i64>) #0
23-
24-
declare void @external_void_func_f16(half) #0
25-
declare void @external_void_func_f32(float) #0
26-
declare void @external_void_func_f64(double) #0
27-
declare void @external_void_func_v2f32(<2 x float>) #0
28-
declare void @external_void_func_v2f64(<2 x double>) #0
29-
declare void @external_void_func_v3f64(<3 x double>) #0
30-
31-
declare void @external_void_func_v2i16(<2 x i16>) #0
32-
declare void @external_void_func_v2f16(<2 x half>) #0
33-
declare void @external_void_func_v3i16(<3 x i16>) #0
34-
declare void @external_void_func_v3f16(<3 x half>) #0
35-
declare void @external_void_func_v4i16(<4 x i16>) #0
36-
declare void @external_void_func_v4f16(<4 x half>) #0
37-
38-
declare void @external_void_func_v2i32(<2 x i32>) #0
39-
declare void @external_void_func_v3i32(<3 x i32>) #0
40-
declare void @external_void_func_v3i32_i32(<3 x i32>, i32) #0
41-
declare void @external_void_func_v4i32(<4 x i32>) #0
42-
declare void @external_void_func_v8i32(<8 x i32>) #0
43-
declare void @external_void_func_v16i32(<16 x i32>) #0
44-
declare void @external_void_func_v32i32(<32 x i32>) #0
45-
declare void @external_void_func_v32i32_i32(<32 x i32>, i32) #0
6+
declare hidden void @external_void_func_i1(i1) #0
7+
declare hidden void @external_void_func_i1_signext(i1 signext) #0
8+
declare hidden void @external_void_func_i1_zeroext(i1 zeroext) #0
9+
10+
declare hidden void @external_void_func_i8(i8) #0
11+
declare hidden void @external_void_func_i8_signext(i8 signext) #0
12+
declare hidden void @external_void_func_i8_zeroext(i8 zeroext) #0
13+
14+
declare hidden void @external_void_func_i16(i16) #0
15+
declare hidden void @external_void_func_i16_signext(i16 signext) #0
16+
declare hidden void @external_void_func_i16_zeroext(i16 zeroext) #0
17+
18+
declare hidden void @external_void_func_i32(i32) #0
19+
declare hidden void @external_void_func_i64(i64) #0
20+
declare hidden void @external_void_func_v2i64(<2 x i64>) #0
21+
declare hidden void @external_void_func_v3i64(<3 x i64>) #0
22+
declare hidden void @external_void_func_v4i64(<4 x i64>) #0
23+
24+
declare hidden void @external_void_func_f16(half) #0
25+
declare hidden void @external_void_func_f32(float) #0
26+
declare hidden void @external_void_func_f64(double) #0
27+
declare hidden void @external_void_func_v2f32(<2 x float>) #0
28+
declare hidden void @external_void_func_v2f64(<2 x double>) #0
29+
declare hidden void @external_void_func_v3f64(<3 x double>) #0
30+
31+
declare hidden void @external_void_func_v2i16(<2 x i16>) #0
32+
declare hidden void @external_void_func_v2f16(<2 x half>) #0
33+
declare hidden void @external_void_func_v3i16(<3 x i16>) #0
34+
declare hidden void @external_void_func_v3f16(<3 x half>) #0
35+
declare hidden void @external_void_func_v4i16(<4 x i16>) #0
36+
declare hidden void @external_void_func_v4f16(<4 x half>) #0
37+
38+
declare hidden void @external_void_func_v2i32(<2 x i32>) #0
39+
declare hidden void @external_void_func_v3i32(<3 x i32>) #0
40+
declare hidden void @external_void_func_v3i32_i32(<3 x i32>, i32) #0
41+
declare hidden void @external_void_func_v4i32(<4 x i32>) #0
42+
declare hidden void @external_void_func_v8i32(<8 x i32>) #0
43+
declare hidden void @external_void_func_v16i32(<16 x i32>) #0
44+
declare hidden void @external_void_func_v32i32(<32 x i32>) #0
45+
declare hidden void @external_void_func_v32i32_i32(<32 x i32>, i32) #0
4646

4747
; return value and argument
48-
declare i32 @external_i32_func_i32(i32) #0
48+
declare hidden i32 @external_i32_func_i32(i32) #0
4949

5050
; Structs
51-
declare void @external_void_func_struct_i8_i32({ i8, i32 }) #0
52-
declare void @external_void_func_byval_struct_i8_i32({ i8, i32 } addrspace(5)* byval) #0
53-
declare void @external_void_func_sret_struct_i8_i32_byval_struct_i8_i32({ i8, i32 } addrspace(5)* sret, { i8, i32 } addrspace(5)* byval) #0
51+
declare hidden void @external_void_func_struct_i8_i32({ i8, i32 }) #0
52+
declare hidden void @external_void_func_byval_struct_i8_i32({ i8, i32 } addrspace(5)* byval) #0
53+
declare hidden void @external_void_func_sret_struct_i8_i32_byval_struct_i8_i32({ i8, i32 } addrspace(5)* sret, { i8, i32 } addrspace(5)* byval) #0
5454

55-
declare void @external_void_func_v16i8(<16 x i8>) #0
55+
declare hidden void @external_void_func_v16i8(<16 x i8>) #0
5656

5757

5858
; FIXME: Should be passing -1
@@ -764,8 +764,8 @@ entry:
764764
ret void
765765
}
766766

767-
declare void @byval_align16_f64_arg(<32 x i32>, double addrspace(5)* byval align 16) #0
768-
declare void @stack_passed_f64_arg(<32 x i32>, double) #0
767+
declare hidden void @byval_align16_f64_arg(<32 x i32>, double addrspace(5)* byval align 16) #0
768+
declare hidden void @stack_passed_f64_arg(<32 x i32>, double) #0
769769

770770
attributes #0 = { nounwind }
771771
attributes #1 = { nounwind readnone }

‎llvm/test/CodeGen/AMDGPU/call-constexpr.ll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ define amdgpu_kernel void @test_bitcast_argument_and_return_types() #0 {
6767
; GCN: s_waitcnt
6868
; GCN-NEXT: v_add_i32_e32 v0, vcc, v1, v0
6969
; GCN-NEXT: s_setpc_b64
70-
define i32 @use_workitem_id_x(i32 %arg0) #0 {
70+
define hidden i32 @use_workitem_id_x(i32 %arg0) #0 {
7171
%id = call i32 @llvm.amdgcn.workitem.id.x()
7272
%op = add i32 %id, %arg0
7373
ret i32 %op
@@ -121,15 +121,15 @@ continue:
121121
; Callees appears last in source file to test that we still lower their
122122
; arguments before we lower any calls to them.
123123

124-
define i32 @ret_i32_noinline() #0 {
124+
define hidden i32 @ret_i32_noinline() #0 {
125125
ret i32 4
126126
}
127127

128-
define i32 @ret_i32_alwaysinline() #1 {
128+
define hidden i32 @ret_i32_alwaysinline() #1 {
129129
ret i32 4
130130
}
131131

132-
define i32 @ident_i32(i32 %i) #0 {
132+
define hidden i32 @ident_i32(i32 %i) #0 {
133133
ret i32 %i
134134
}
135135

‎llvm/test/CodeGen/AMDGPU/call-preserved-registers.ll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=hawaii -enable-ipra=0 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
33
; RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx900 -enable-ipra=0 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s
44

5-
declare void @external_void_func_void() #0
5+
declare hidden void @external_void_func_void() #0
66

77
; GCN-LABEL: {{^}}test_kernel_call_external_void_func_void_clobber_s30_s31_call_external_void_func_void:
88
; GCN: s_mov_b32 s33, s7
@@ -84,7 +84,7 @@ define void @void_func_void_clobber_s30_s31() #2 {
8484
; GCN-NEXT: ;;#ASMSTART
8585
; GCN-NEXT: ;;#ASMEND
8686
; GCN-NEXT: s_setpc_b64 s[30:31]
87-
define void @void_func_void_clobber_vcc() #2 {
87+
define hidden void @void_func_void_clobber_vcc() #2 {
8888
call void asm sideeffect "", "~{VCC}"() #0
8989
ret void
9090
}
@@ -176,7 +176,7 @@ define amdgpu_kernel void @test_call_void_func_void_preserves_v32(i32 addrspace(
176176
; GCN-NEXT: #ASMEND
177177
; GCN-NEXT: v_readlane_b32 s33, v0, 0
178178
; GCN-NEXT: s_setpc_b64
179-
define void @void_func_void_clobber_s33() #2 {
179+
define hidden void @void_func_void_clobber_s33() #2 {
180180
call void asm sideeffect "; clobber", "~{s33}"() #0
181181
ret void
182182
}

‎llvm/test/CodeGen/AMDGPU/cross-block-use-is-not-abi-copy.ll

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,11 @@ bb1:
166166
}
167167

168168

169-
declare <2 x float> @func_v2f32() #0
170-
declare <3 x float> @func_v3f32() #0
171-
declare <4 x float> @func_v4f32() #0
172-
declare <4 x half> @func_v4f16() #0
169+
declare hidden <2 x float> @func_v2f32() #0
170+
declare hidden <3 x float> @func_v3f32() #0
171+
declare hidden <4 x float> @func_v4f32() #0
172+
declare hidden <4 x half> @func_v4f16() #0
173173

174-
declare { <4 x i32>, <4 x half> } @func_struct() #0
174+
declare hidden { <4 x i32>, <4 x half> } @func_struct() #0
175175

176176
attributes #0 = { nounwind}

‎llvm/test/CodeGen/AMDGPU/ipra.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ entry:
1212

1313
; GCN-LABEL: {{^}}func:
1414
; GCN: ; NumVgprs: 8
15-
define void @func() #1 {
15+
define hidden void @func() #1 {
1616
call void asm sideeffect "", "~{v0},~{v1},~{v2},~{v3},~{v4},~{v5},~{v6},~{v7}"() #0
1717
ret void
1818
}

‎llvm/test/CodeGen/AMDGPU/mem-builtins.ll

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
; RUN: not llc -march=r600 < %s 2>&1 | FileCheck -check-prefix=ERROR %s
22
; RUN: llc -march=amdgcn < %s | FileCheck -check-prefix=GCN %s
33

4-
declare i32 @memcmp(i8 addrspace(1)* readonly nocapture, i8 addrspace(1)* readonly nocapture, i64) #0
5-
declare i8 addrspace(1)* @memchr(i8 addrspace(1)* readonly nocapture, i32, i64) #1
6-
declare i8* @strcpy(i8* nocapture, i8* readonly nocapture) #0
7-
declare i32 @strlen(i8* nocapture) #1
8-
declare i32 @strnlen(i8* nocapture, i32) #1
9-
declare i32 @strcmp(i8* nocapture, i8* nocapture) #1
4+
declare hidden i32 @memcmp(i8 addrspace(1)* readonly nocapture, i8 addrspace(1)* readonly nocapture, i64) #0
5+
declare hidden i8 addrspace(1)* @memchr(i8 addrspace(1)* readonly nocapture, i32, i64) #1
6+
declare hidden i8* @strcpy(i8* nocapture, i8* readonly nocapture) #0
7+
declare hidden i32 @strlen(i8* nocapture) #1
8+
declare hidden i32 @strnlen(i8* nocapture, i32) #1
9+
declare hidden i32 @strcmp(i8* nocapture, i8* nocapture) #1
1010

1111

1212
; ERROR: error: <unknown>:0:0: in function test_memcmp void (i8 addrspace(1)*, i8 addrspace(1)*, i32*): unsupported call to function memcmp

‎llvm/test/CodeGen/AMDGPU/sibling-call.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ define fastcc i32 @i32_fastcc_i32_i32_stack_object(i32 %arg0, i32 %arg1) #1 {
3232
}
3333

3434
; GCN-LABEL: {{^}}sibling_call_i32_fastcc_i32_i32:
35-
define fastcc i32 @sibling_call_i32_fastcc_i32_i32(i32 %a, i32 %b, i32 %c) #1 {
35+
define hidden fastcc i32 @sibling_call_i32_fastcc_i32_i32(i32 %a, i32 %b, i32 %c) #1 {
3636
entry:
3737
%ret = tail call fastcc i32 @i32_fastcc_i32_i32(i32 %a, i32 %b)
3838
ret i32 %ret
@@ -92,7 +92,7 @@ entry:
9292
; GFX9-NEXT: v_add_u32_e32 v0, v0, v1
9393

9494
; GCN-NEXT: s_setpc_b64 s[30:31]
95-
define fastcc i32 @i32_fastcc_i32_byval_i32(i32 %arg0, i32 addrspace(5)* byval align 4 %arg1) #1 {
95+
define hidden fastcc i32 @i32_fastcc_i32_byval_i32(i32 %arg0, i32 addrspace(5)* byval align 4 %arg1) #1 {
9696
%arg1.load = load i32, i32 addrspace(5)* %arg1, align 4
9797
%add0 = add i32 %arg0, %arg1.load
9898
ret i32 %add0

0 commit comments

Comments
 (0)