Skip to content

Commit c8ba551

Browse files
authored
[AArch64] Return early rather than asserting when Size of value passed to targetShrinkDemandedConstant is not 32 or 64 (#123084)
See #123029 for details.
1 parent 3c42a77 commit c8ba551

File tree

2 files changed

+51
-2
lines changed

2 files changed

+51
-2
lines changed

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2373,8 +2373,9 @@ bool AArch64TargetLowering::targetShrinkDemandedConstant(
23732373
return false;
23742374

23752375
unsigned Size = VT.getSizeInBits();
2376-
assert((Size == 32 || Size == 64) &&
2377-
"i32 or i64 is expected after legalization.");
2376+
2377+
if (Size != 32 && Size != 64)
2378+
return false;
23782379

23792380
// Exit early if we demand all bits.
23802381
if (DemandedBits.popcount() == Size)
Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
2+
; RUN: llc --mtriple=aarch64-unknown-linux-gnu < %s | FileCheck %s
3+
4+
; Check that the following does not crash
5+
; See https://github.com/llvm/llvm-project/issues/123029 for details
6+
7+
define ptr @fn(ptr %in, ptr %out) {
8+
; CHECK-LABEL: fn:
9+
; CHECK: // %bb.0: // %fn
10+
; CHECK-NEXT: ldr d1, [x0]
11+
; CHECK-NEXT: movi v0.4h, #60, lsl #8
12+
; CHECK-NEXT: adrp x8, .LCPI0_0
13+
; CHECK-NEXT: fcvtl v1.4s, v1.4h
14+
; CHECK-NEXT: fcmgt v2.4s, v1.4s, #0.0
15+
; CHECK-NEXT: fcmlt v1.4s, v1.4s, #0.0
16+
; CHECK-NEXT: orr v1.16b, v1.16b, v2.16b
17+
; CHECK-NEXT: ldr h2, [x8, :lo12:.LCPI0_0]
18+
; CHECK-NEXT: xtn v1.4h, v1.4s
19+
; CHECK-NEXT: and v0.8b, v1.8b, v0.8b
20+
; CHECK-NEXT: movi d1, #0000000000000000
21+
; CHECK-NEXT: str d0, [x1]
22+
; CHECK-NEXT: ldr h0, [x0, #8]
23+
; CHECK-NEXT: mov x0, xzr
24+
; CHECK-NEXT: fcvt s0, h0
25+
; CHECK-NEXT: fcmp s0, #0.0
26+
; CHECK-NEXT: fcsel s1, s2, s1, mi
27+
; CHECK-NEXT: fcsel s1, s2, s1, gt
28+
; CHECK-NEXT: mvni v2.4s, #128, lsl #24
29+
; CHECK-NEXT: fcvt s1, h1
30+
; CHECK-NEXT: bit v0.16b, v1.16b, v2.16b
31+
; CHECK-NEXT: fcvt h0, s0
32+
; CHECK-NEXT: str h0, [x1, #8]
33+
; CHECK-NEXT: ret
34+
fn:
35+
%1 = load <4 x half>, ptr %in
36+
%2 = fcmp one <4 x half> %1, zeroinitializer
37+
%3 = uitofp <4 x i1> %2 to <4 x half>
38+
store <4 x half> %3, ptr %out
39+
40+
%4 = getelementptr inbounds nuw i8, ptr %in, i64 8
41+
%5 = load half, ptr %4
42+
%6 = fcmp one half %5, 0xH0000
43+
%7 = uitofp i1 %6 to half
44+
%8 = call half @llvm.copysign.f16(half %7, half %5)
45+
%9 = getelementptr inbounds nuw i8, ptr %out, i64 8
46+
store half %8, ptr %9
47+
ret ptr null
48+
}

0 commit comments

Comments
 (0)